-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Press0 1328 default to light mode #565
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ajayadav09, can we explore using useEffect
instead of an event listener, and can we fix the failing tests? Thanks!
@arunshenoy99 I tried the useEffect approach to check for changes but the window.matchMedia is a function provided by the window object and it does not change between renders. So to check for changes will have to add listeners to matchMedia. |
Proposed changes
Default to light mode unless the user has prefer-color-scheme as dark mode.
Type of Change
Checklist
Further comments