-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/region links #27
Conversation
Still don't have a clear way to determine the actual region. We'll need to devise that, maybe there is something we can use already or we may have the installer set an option on install. Need to do some research into what they currently do. If we end up using something other than the brand value, let's also consider passing it to the hiive - likely as a site meta value. |
…egions, move market data to assets dir as json files, add images for BR region services
…the hg app page, allow json files in build too.
don't concatenate modules set terser mangle reserved options exclude src files in i18n make commands preserve translator comments in js make new pot update pt_BR po file to reflect new pot
fix instances in build.js where __() was not preserved from source file wrap a couple strings in i18n that had been missed make new pot update pt_BR po file to reflect new pot generate new pt_BR mo file generate new json file
@wpscholar - would you mind reviewing again? It wasn't a huge amount of changes since you reviewed it last, but I wanted to get a second pair of eyes on it at least. The i18n steps are not fully automated, but I'm not sure we can automate them since the language file is in place now. We can update it to at least keep the .pot file updated if strings change and it will be up to us to get the new translation strings into the .po files and then create the .mo and .json files from that. |
Creating an object map for region links and some helper methods to load them.
Also adds a new helper method for adding utm params to links.