-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AWS Pinpoint #1671
Merged
scwambach
merged 3 commits into
scott/NJWE-1180-collect-user-information
from
ckr/aws-pinpoint
Nov 20, 2023
Merged
AWS Pinpoint #1671
scwambach
merged 3 commits into
scott/NJWE-1180-collect-user-information
from
ckr/aws-pinpoint
Nov 20, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scwambach
approved these changes
Nov 20, 2023
scwambach
merged commit Nov 20, 2023
3f4717e
into
scott/NJWE-1180-collect-user-information
1 of 2 checks passed
scwambach
added a commit
that referenced
this pull request
Jan 24, 2024
* re-enabled career pathways for v2.1 * ran prettier * NJWE-885 * table of contents nav * Update DropGroup.tsx * Update TabContent.tsx * fix button styles on search * Update parseMarkdownToHTML.ts * Add deploy * notifier start * desktop styles * all but where to send form * remove heading replace with paragraph tag * Update UpdateNotifier.tsx * Update TrainingExplorerPage.tsx * overlay * push * Update _introBlocks.scss * Career Navigator - Why to use cards - Mobile, Desktop * Training Explorer - FAQ section - Spacing (Mobile, Desktop) * Update _training-explorer.scss * TE - Title Section text size - Mobile * NJCC - Hero Section Spacing - Mobile * TE - Find Training Page - Quick Fix * TE - Training Search Spacing - Mobile * NJCC - To Top Button Z-index * Update navigation_paths.js * Update _stepper.scss * related training open in new tab * Update index.html * fix deploy * renamed '/training-explorer' route to '/training' by client request * updated notifier * Update UpdateNotifier.tsx * re-enable Career Pathways link * AWS Pinpoint (#1671) * init * rm * rm * successful submissions * status messaging * Update training-page.cy.js * jest test * temp homepage test change * Update home-page.cy.js * Update UpdateNotifier.tsx * allow waiting in cypress * Update _tab-content.scss * Update _tab-content.scss * Scott/updated nav (#1772) * Update Layout.tsx * Update home-page.cy.js * organized the career details * more cleanup * order correction * added missing comma from merge * Added @testing-library/user-event * Add Pinpoint endpoint management * Refactor AWS SDK Config Initialization for EC2 IAM Role Compatibility This commit updates the AWS SDK configuration setup in our application. It modifies the way we initialize the AWS Config object to better support EC2 IAM Role credentials. Now, the `accessKeyId` and `secretAccessKey` are conditionally set based on the availability of their respective environment variables. If these environment variables are absent, the application defaults to using the IAM role attached to the EC2 instance, enhancing security and deployment flexibility. - Use direct object construction in AWS.Config for clarity and conciseness. - Employ conditional logic to set `accessKeyId` and `secretAccessKey`. - Ensure that if no environment variables are set, IAM role credentials are used automatically by the AWS SDK. - Address ESLint warning about variable reassignment by using const. - Improve compatibility with different deployment environments, particularly AWS EC2 with IAM roles. * feature flags * resetting back * walking it back * eof char * test updates * search fix * test fix * Update LandingPage.tsx * Update home-page.cy.js * replaced "displays training details" with latest * show navigator * review fixes * Career Navigator Flag * Update LandingPage.tsx * Update README.md * Update .env.sample * Update career-navigator-page.cy.js --------- Co-authored-by: Chelsea Kelly-Reif (she/her) <ckellyreif@gmail.com> Co-authored-by: Chelsea Kelly-Reif <chelsea.kelly-reif@coforma.io>
scwambach
added a commit
that referenced
this pull request
Jan 29, 2024
* re-enabled career pathways for v2.1 * ran prettier * NJWE-885 * table of contents nav * Update DropGroup.tsx * Update TabContent.tsx * fix button styles on search * Update parseMarkdownToHTML.ts * Add deploy * notifier start * desktop styles * all but where to send form * remove heading replace with paragraph tag * Update UpdateNotifier.tsx * Update TrainingExplorerPage.tsx * overlay * push * Update _introBlocks.scss * Career Navigator - Why to use cards - Mobile, Desktop * Training Explorer - FAQ section - Spacing (Mobile, Desktop) * Update _training-explorer.scss * TE - Title Section text size - Mobile * NJCC - Hero Section Spacing - Mobile * TE - Find Training Page - Quick Fix * TE - Training Search Spacing - Mobile * NJCC - To Top Button Z-index * Update navigation_paths.js * Update _stepper.scss * related training open in new tab * Update index.html * fix deploy * renamed '/training-explorer' route to '/training' by client request * updated notifier * Update UpdateNotifier.tsx * re-enable Career Pathways link * AWS Pinpoint (#1671) * init * rm * rm * successful submissions * status messaging * Update training-page.cy.js * jest test * temp homepage test change * Update home-page.cy.js * Update UpdateNotifier.tsx * allow waiting in cypress * Update _tab-content.scss * Update _tab-content.scss * Scott/updated nav (#1772) * Update Layout.tsx * Update home-page.cy.js * organized the career details * more cleanup * order correction * added missing comma from merge * Added @testing-library/user-event * Add Pinpoint endpoint management * Refactor AWS SDK Config Initialization for EC2 IAM Role Compatibility This commit updates the AWS SDK configuration setup in our application. It modifies the way we initialize the AWS Config object to better support EC2 IAM Role credentials. Now, the `accessKeyId` and `secretAccessKey` are conditionally set based on the availability of their respective environment variables. If these environment variables are absent, the application defaults to using the IAM role attached to the EC2 instance, enhancing security and deployment flexibility. - Use direct object construction in AWS.Config for clarity and conciseness. - Employ conditional logic to set `accessKeyId` and `secretAccessKey`. - Ensure that if no environment variables are set, IAM role credentials are used automatically by the AWS SDK. - Address ESLint warning about variable reassignment by using const. - Improve compatibility with different deployment environments, particularly AWS EC2 with IAM roles. * feature flags * resetting back * walking it back * eof char * test updates * search fix * test fix * Update LandingPage.tsx * Update home-page.cy.js * replaced "displays training details" with latest * show navigator * review fixes * fields * error handling and comments * Update UpdateNotifier.tsx * Update _updateNotifier.scss * Update App.tsx * Update UpdateNotifier.tsx * review requests * teeny tiny change --------- Co-authored-by: Chelsea Kelly-Reif (she/her) <ckellyreif@gmail.com> Co-authored-by: Chelsea Kelly-Reif <chelsea.kelly-reif@coforma.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will get you started :-)