Backport CASSANDRA-10340 and CASSANDRA-13038 #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upstream commit: f1cabca
In ttl-heavy use cases (especially tables with default time to live set), the streaming histograms calculated during compaction and streaming are very inefficient. This patch addresses that in two ways: 1) It creates a system property -Dcassandra.streaminghistogram.roundseconds=60, and rounds all histograms to the next highest multiple of that value, and 2) Rather than maintaining a histogram of 100 bins that have to be merged on every new value, we keep a temporary spool of 100000 bins, and merge down to the 100 bin final histogram only when the temporary spool overflows. Patch by Jeff Jirsa; Reviewed by Nate McCall for CASSANDRA-13038 Upstream commit: a5ce963
patch by Stefan Podkowinski; reviewed by jasobrown for CASSANDRA-13040 Upstream commit: b8ed255
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These two changes should make streaming operations faster, which would speed up bootstrapping and node moves.