Convert to WebP & pre-commit hook #12590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- this change adds `yarn convert-to-webp` command - this checks for PNG images, converts them to WebP, then updates markdown references
tabathadelane
requested review from
a team,
sunnyzanchi and
clarkmcadoo
and removed request for
a team
github-actions
bot
added
the
eng
|
Hi @tabathadelane 👋 Thanks for your pull request! Your PR is in a queue, and a writer will take a look soon. We generally publish small edits within one business day, and larger edits within three days. Gatsby Cloud will automatically generate a preview of your request, and will comment with a link when the preview is ready (usually 20 to 30 minutes). |
✅ docs-website-develop deploy preview ready
|
clarkmcadoo
previously approved these changes
Apr 14, 2023
* check literal `.` in `stagedMDs` regex * use `continue` instead of `break` to avoid early exit * update convert-to-webp script to include jpgs * add error logging to convert-to-webp * run Prettier
sunnyzanchi
previously approved these changes
Apr 17, 2023
|
|
||
| import { rm, readFile, writeFile } from 'fs/promises'; | ||
| import { glob } from 'glob10'; | ||
| // installed with an alias because v10 conflicts with jest dependencies |
There was a problem hiding this comment.
nit: can you move this a line up? comments are usually above the line they refer to
| @@ -28,6 +28,10 @@ const main = async () => { | |||
|
|
|||
| console.log(results); | |||
| console.log(`Failed file count: ${results.length}`); | |||
|
|
|||
| if (results.length > 0) { | |||
| process.exitCode = 1; | |||
sunnyzanchi
approved these changes
Apr 17, 2023
clarkmcadoo
approved these changes
Apr 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
webp-converterpackage to convert PNG images to WebPconvertPNGs.mjsscript to convert repo PNGs to WebP formatglobpackage to grab all png/markdown/js filesglob10because jest is using glob v7 as a dependency and it was causing major conflicts to install a newer versionmeowpackage for flag support to run script on staged vs global fileshuskypackage for pre-commit checkspre-commit.mjsscript that warns contributors on png image uploadspackage.jsonscripts in ascending orderyarn lintandyarn pre-committo required checks that must pass before staged files can be committedScript can be run on staged files with command
yarn convert-to-webpScript can be run globally on entire repo with command
yarn convert-to-webp -gNOTE: The pre-commit.sh scripts have been temporarily disabled until we can coordinate with writers about this change.
NOTE: 😢 Github desktop does not 🙅♀️ support bash escape characters to change 🎨ANSI colors, so the pre-commit failure message can only use emojis
replaces #12317