Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logs not supported yet on ubuntun 24.04 #17401

Merged
merged 5 commits into from
May 22, 2024
Merged

Logs not supported yet on ubuntun 24.04 #17401

merged 5 commits into from
May 22, 2024

Conversation

danybmx
Copy link
Contributor

@danybmx danybmx commented May 22, 2024

Give us some context

  • What problems does this PR solve?

Infra agent nows support ubuntu 24.04 but logs are not supported there, this adds an extra note on the changelog and installation of infra-agent to let the user know.

  • Add any context that will help us review your changes such as testing notes,
    links to related docs, screenshots, etc.

Fluent-bit (the forwarder logs using) didn't release an ubuntu 24.04 version yet.

@CLAassistant
Copy link

CLAassistant commented May 22, 2024

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
8 out of 9 committers have signed the CLA.

✅ bradleycamacho
✅ rhetoric101
✅ homelessbirds
✅ sunnyzanchi
✅ tabathadelane
✅ ally-sassman
✅ jeff-colucci
✅ akristen
❌ danybmx
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link

Hi @danybmx 👋

Thanks for your pull request! Your PR is in a queue, and a writer will take a look soon. We generally publish small edits within one business day, and larger edits within three days.

We will automatically generate a preview of your request, and will comment with a link when the preview is ready (usually 10 to 20 minutes).

Copy link

netlify bot commented May 22, 2024

Deploy Preview for docs-website-netlify ready!

Name Link
🔨 Latest commit bb3b2fe
🔍 Latest deploy log https://app.netlify.com/sites/docs-website-netlify/deploys/664e3f7f46bbb4000844717c
😎 Deploy Preview https://deploy-preview-17401--docs-website-netlify.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@danybmx danybmx changed the base branch from develop to main May 22, 2024 15:34
@ally-sassman ally-sassman added content requests related to docs site content from_internal Identifies issues/PRs from Relics (except writers) labels May 22, 2024
ally-sassman
ally-sassman previously approved these changes May 22, 2024
@danybmx
Copy link
Contributor Author

danybmx commented May 22, 2024

Hi @ally-sassman thanks for the suggestions! I don't know why the validate javascript check is failing 🤔

@danybmx danybmx changed the base branch from main to develop May 22, 2024 18:55
@danybmx danybmx dismissed ally-sassman’s stale review May 22, 2024 18:55

The base branch was changed.

@ally-sassman
Copy link
Contributor

I got docs engineering approval to merge this in w/o the checks passing (they did troubleshooting on the side).

@ally-sassman ally-sassman merged commit 5b0eafd into newrelic:develop May 22, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content requests related to docs site content from_internal Identifies issues/PRs from Relics (except writers)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants