Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update heroku-log-forwarding.mdx #18044

Merged
merged 3 commits into from
Jul 17, 2024
Merged

Update heroku-log-forwarding.mdx #18044

merged 3 commits into from
Jul 17, 2024

Conversation

hrai-nr
Copy link
Contributor

@hrai-nr hrai-nr commented Jul 17, 2024

Changing the documentation to reflect new changes

Please follow conventional commit standards
in your commit messages and pull request title.

Give us some context

  • What problems does this PR solve? - This will align our documentation to our product. Earlier it was saying Click Generate URL, but there is no such button.
  • Add any context that will help us review your changes such as testing notes,
    links to related docs, screenshots, etc.
  • If your issue relates to an existing GitHub issue, please link to it.

Changing the documentation to reflect new changes
@CLAassistant
Copy link

CLAassistant commented Jul 17, 2024

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link

Hi @hrai-nr 👋

Thanks for your pull request! Your PR is in a queue, and a writer will take a look soon. We generally publish small edits within one business day, and larger edits within three days.

We will automatically generate a preview of your request, and will comment with a link when the preview is ready (usually 10 to 20 minutes).

Copy link

netlify bot commented Jul 17, 2024

Deploy Preview for docs-website-netlify ready!

Name Link
🔨 Latest commit f71c491
🔍 Latest deploy log https://app.netlify.com/sites/docs-website-netlify/deploys/6697745d495a530008a498b8
😎 Deploy Preview https://deploy-preview-18044--docs-website-netlify.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nbaenam
Copy link
Contributor

nbaenam commented Jul 17, 2024

Hi @hrai-nr, could you please sign the CLA by clicking the yellow button a few messages above this one? I'll be able to merge in as soon as you do. Thanks!

@nbaenam nbaenam self-requested a review July 17, 2024 07:23
@nbaenam nbaenam self-assigned this Jul 17, 2024
@nbaenam nbaenam added content requests related to docs site content from_internal Identifies issues/PRs from Relics (except writers) labels Jul 17, 2024
Copy link
Contributor

@nbaenam nbaenam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @hrai-nr, thank you for fixing this! I've added a minor TW edit.

@nbaenam nbaenam merged commit 1bf20df into newrelic:develop Jul 17, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content requests related to docs site content from_internal Identifies issues/PRs from Relics (except writers)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants