Raise if not running OTP 21 #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
binaryseed
force-pushed
the
require-otp-21
branch
from
834354c
to
ccd0eb7
Compare
mattbaker
approved these changes
Oct 24, 2019
|
Upcoming Elixir |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will cause the agent to fail fast if the application is pre-OTP 21. We already rely on some features in OTP 21 and the agent will fail with unhelpful errors.
I considered other options like not starting the application supervision tree but that may cause it's own set of problems if there are calls to
NewRelicfunctions for instrumentation, etc. Open to thoughts on this...closes #150
closes #138
sidekick/ @mattbaker