Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_integrations/nrlogrus/nrlogrus.go should import lowercase "github.com/sirupsen/logrus" #55

Closed
voidrot opened this issue Jul 20, 2017 · 4 comments

Comments

@voidrot
Copy link

voidrot commented Jul 20, 2017

Currently the nrlogrus.StandardLogger() imports "github.com/Sirupsen/logrus". This causes errors inside of existing projects that are already using logrus as described in in their README.

Seeing weird case-sensitive problems? It's in the past been possible to import Logrus as both upper- and lower-case. Due to the Go package environment, this caused issues in the community and we needed a standard. Some environments experienced problems with the upper-case variant, so the lower-case was decided. Everything using logrus will need to use the lower-case: github.com/sirupsen/logrus. Any package that isn't, should be changed.

There is an open pull request for this already #52

@voidrot voidrot changed the title nrlogrus.StandardLogger() should import lowercase "github.com/sirupsen/logrus" _integrations/nrlogrus/nrlogrus.go should import lowercase "github.com/sirupsen/logrus" Jul 20, 2017
@ghost
Copy link

ghost commented Oct 5, 2017

Thanks for pointing it out to us @adminfromhell . I've replied in the open pull request and have merged the fix to our testing environment. Expect the fix to be part of our next release!

@ghost ghost closed this as completed Oct 5, 2017
sergeylanzman pushed a commit to sergeylanzman/go-agent that referenced this issue Oct 5, 2017
@alif
Copy link

alif commented Oct 20, 2017

Any update on when this will be released? Is the next release coming soon?
Thanks!

@crenshaw
Copy link

Thanks for your inquiry. This change is included in our next release which is currently undergoing quality assurance testing. I'm hopeful we'll see something in the coming weeks.

@crenshaw
Copy link

This fix is available in release 1.10.0, out today.
See: https://github.com/newrelic/go-agent/tree/v1.10.0

The CHANGELOG.md describes all the latest updates.
See: https://source.datanerd.us/go-agent/go-agent/blob/master/CHANGELOG.md

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants