Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test dependancies fixes #534

Merged
merged 24 commits into from
Jul 19, 2022
Merged

Conversation

mirackara
Copy link
Contributor

@mirackara mirackara commented Jul 6, 2022

Includes fixes/dependancy bumps for the following tests
nrgraphqlgo
nrhttprouter
nrgorilla
nrredis
nrgraphgophers
nrzap
nrmicro
nrlogrusplugin
nrecho-v3

Includes removal of following legacy tests
nrnats
nrmssql
nrzap
nrstan

Note: While the legacy versions of these tests are being removed, they still exist under the v3 versions of the integrations.

@mirackara mirackara changed the base branch from master to develop July 6, 2022 18:47
@CLAassistant
Copy link

CLAassistant commented Jul 6, 2022

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ nr-swilloughby
❌ Mirac Kara


Mirac Kara seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Mirac Kara seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@mirackara mirackara marked this pull request as ready for review July 12, 2022 15:19
@iamemilio
Copy link
Contributor

This PR is good to merge. Thanks for fixing this Mirac, this will have a big impact on the team being able to deliver software!

iamemilio
iamemilio previously approved these changes Jul 12, 2022
@iamemilio iamemilio merged commit 31f62f6 into newrelic:develop Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix v3/nrgraphql test Fix Broken v3/nrelasticsearch-v7 unit test fix broken v3/nrawssdk-v1 unit test
4 participants