add zerolog support for agent logs #617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesgoodhouse
force-pushed
the
add_zerolog_integration
branch
from
a87d96a
to
180c41c
Compare
jamesgoodhouse
force-pushed
the
add_zerolog_integration
branch
from
180c41c
to
54d85ec
Compare
jamesgoodhouse
force-pushed
the
add_zerolog_integration
branch
from
54d85ec
to
aac5acd
Compare
jamesgoodhouse
changed the title
|
|
|
@jamesgoodhouse Please sign the CLA |
|
What can be done to move this forward if the CLA is not signed further? We are hoping to use the zerolog integration in our apps as well |
iamemilio
previously approved these changes
Jul 29, 2024
|
Unfortunately, we can not use this code as written until the CLA is accepted, since we do not have the rights to it. We can create a ticket to create our own code as a feature request though. Legally, none of the code in this pull request can be used by us unfortunately. |
|
@jamesgoodhouse One more ping 🙏 . I'll resolve your merge conflicts, just sign the CLA? |
|
@iamemilio signed! |
iamemilio
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Links
https://github.com/rs/zerolog
Details
This adds a Zerolog integration for use with the agent's log system.