Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat instrument pgx CopyFrom #826

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

vinicius-batista
Copy link

Links

Closes #825

Details

The implementation and tests was simple but I have a problem running tests when snapshot was already created.
The current installed version from pgsnap fails when read CopyData from snapshot.
At pgsnap's latest version CopyData and other messages were implemented but pgproto is failing to unmarshal CopyInResponse message.

I don't know how to proceed with this implementation as some tests are failing due to external dependencies.

@CLAassistant
Copy link

CLAassistant commented Nov 23, 2023

CLA assistant check
All committers have signed the CLA.

@vinicius-batista
Copy link
Author

@iamemilio

@iamemilio iamemilio self-requested a review November 27, 2023 18:31
@codecov-commenter
Copy link

codecov-commenter commented Nov 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d752b7e) 80.06% compared to head (dc1ed85) 80.37%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #826      +/-   ##
===========================================
+ Coverage    80.06%   80.37%   +0.30%     
===========================================
  Files          136      138       +2     
  Lines        12358    12489     +131     
===========================================
+ Hits          9895    10038     +143     
+ Misses        2180     2169      -11     
+ Partials       283      282       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nr-swilloughby
Copy link
Contributor

Thanks for your PR. We'll review it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants