Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLM user code location callback alternative to LocationOverride option #838

Merged
merged 3 commits into from
Dec 14, 2023

Conversation

nr-swilloughby
Copy link
Contributor

Fixes Issue #640.
Deprecates the CLM option to set LocationOverride, which forces the caller to do the work to determine the code location up-front even if CLM is disabled. Replaces this with a new function which registers a callback function, which the CLM code will call to get the function location from the user's code only if actually needed. The user's callback may use the existing caching code location functions to further optimize this.

@codecov-commenter
Copy link

codecov-commenter commented Dec 14, 2023

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (e98ff73) 80.33% compared to head (932f589) 80.23%.
Report is 4 commits behind head on develop.

Files Patch % Lines
v3/newrelic/code_level_metrics.go 37.50% 8 Missing and 2 partials ⚠️
v3/newrelic/secure_agent.go 0.00% 5 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #838      +/-   ##
===========================================
- Coverage    80.33%   80.23%   -0.10%     
===========================================
  Files          139      139              
  Lines        12603    12621      +18     
===========================================
+ Hits         10124    10127       +3     
- Misses        2189     2202      +13     
- Partials       290      292       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nr-swilloughby nr-swilloughby merged commit d655461 into newrelic:develop Dec 14, 2023
45 of 48 checks passed
@nr-swilloughby nr-swilloughby deleted the clm640 branch December 14, 2023 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants