-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Agent configuration databind variables support #251
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
varas
changed the title
feat databind cfg
Agent configuration databind variables support
Nov 25, 2020
Pull Request Test Coverage Report for Build 415587773
💛 - Coveralls |
varas
force-pushed
the
feat_databind-cfg
branch
from
December 4, 2020 16:21
ac8663e
to
e32303c
Compare
varas
force-pushed
the
feat_databind-cfg
branch
from
December 4, 2020 16:26
29df054
to
aaa7668
Compare
carlosroman
approved these changes
Dec 11, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice changes. Will add a note somewhere about decoupling the databind providers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds secrets management support for the infrastructure agent configuration file.
Therefore same
variables
section as the one defined for integrations is available.IE:
This also removes AgentMode type, as databind is not handling this well.