Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Env-vars replacement for integrations #266

Merged
merged 12 commits into from
Dec 11, 2020
Merged

Env-vars replacement for integrations #266

merged 12 commits into from
Dec 11, 2020

Conversation

varas
Copy link
Contributor

@varas varas commented Dec 11, 2020 •
edited
Loading

Configuration env-vars replacement for integrations, as done for the agent config.

@varas varas requested a review from a team December 11, 2020 15:03
@varas varas changed the base branch from master to fix_evn-vars-replacement December 11, 2020 15:03
@coveralls
Copy link

coveralls commented Dec 11, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 415895045

  • 41 of 53 (77.36%) changed or added relevant lines in 4 files are covered.
  • 4 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.001%) to 58.163%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/config/envvar/envvar.go 29 31 93.55%
pkg/integrations/v4/manager.go 2 4 50.0%
pkg/config/config.go 9 17 52.94%
Files with Coverage Reduction New Missed Lines %
pkg/integrations/v4/logs/cfg_watcher.go 4 67.5%
Totals Coverage Status
Change from base Build 415871771: -0.001%
Covered Lines: 11400
Relevant Lines: 19600
💛 - Coveralls

carlosroman
carlosroman previously approved these changes Dec 11, 2020
View reviewed changes
Copy link
Contributor

@carlosroman carlosroman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼

Base automatically changed from fix_evn-vars-replacement to master December 11, 2020 16:52
@varas varas dismissed carlosroman’s stale review December 11, 2020 16:52

The base branch was changed.

@varas varas force-pushed the feat_env-vars-replacement-for-integrations branch from 2460ac4 to 385f330 Compare December 11, 2020 16:56
@varas varas changed the title feat env vars replacement for integrations Env-vars replacement for integrations Dec 11, 2020
@varas @carlosroman
Copyright
66e39e9 
Co-authored-by: Carlos <croman@newrelic.com>
@varas varas force-pushed the feat_env-vars-replacement-for-integrations branch from 385f330 to 66e39e9 Compare December 11, 2020 17:04
@varas varas merged commit cfcbb6a into master Dec 11, 2020
@varas varas deleted the feat_env-vars-replacement-for-integrations branch December 11, 2020 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlosroman carlosroman carlosroman left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@varas @coveralls @carlosroman