Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgraded fsnotify to v1.4.9 #78

Merged
merged 1 commit into from
Aug 28, 2020
Merged

Conversation

carlosroman
Copy link
Contributor

The reasons for this PR is to update fsnotify as latest version as some libraries we want to use have issues with old versions of this library (like spf13/cobra).

@coveralls
Copy link

coveralls commented Aug 25, 2020

Pull Request Test Coverage Report for Build 228900000

  • 41 of 98 (41.84%) changed or added relevant lines in 8 files are covered.
  • 10 unchanged lines in 5 files lost coverage.
  • Overall coverage increased (+0.008%) to 55.855%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/integrations/v4/logs/cfg_watcher.go 18 21 85.71%
pkg/integrations/v4/manager.go 21 24 87.5%
internal/plugins/linux/users.go 0 6 0.0%
internal/plugins/linux/dpkg.go 0 10 0.0%
pkg/plugins/files_config.go 0 10 0.0%
internal/plugins/linux/rpm.go 0 11 0.0%
internal/plugins/linux/sysctl_subscriber.go 0 14 0.0%
Files with Coverage Reduction New Missed Lines %
internal/plugins/linux/sysctl_subscriber.go 1 0%
pkg/integrations/v4/manager.go 1 77.21%
pkg/plugins/files_config.go 1 31.9%
pkg/metrics/sampler/sampler_routine.go 2 94.74%
pkg/integrations/v4/logs/cfg_watcher.go 5 67.5%
Totals Coverage Status
Change from base Build 228836491: 0.008%
Covered Lines: 8953
Relevant Lines: 16029

💛 - Coveralls

brushknight
brushknight previously approved these changes Aug 28, 2020
Copy link
Contributor

@brushknight brushknight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cristianciutea
cristianciutea previously approved these changes Aug 28, 2020
@carlosroman carlosroman merged commit c201a61 into master Aug 28, 2020
@carlosroman carlosroman deleted the croman/upgrade-fsnotify branch August 28, 2020 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants