Prevent allocation error #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fahmy-Mohammed
previously approved these changes
Jan 13, 2021
joshuabenuck
force-pushed
the
prevent-allocation-error
branch
2 times, most recently
from
3972f59
to
82d191c
Compare
added 3 commits
January 13, 2021 14:27
* Log stack traces when an allocation error is encountered * Send a Supportability metric about the module length problem * Fix linker error during axiom lib check in agent build
joshuabenuck
force-pushed
the
prevent-allocation-error
branch
from
82d191c
to
ee6cdc0
Compare
kneitinger
previously approved these changes
Jan 21, 2021
zsistla
previously approved these changes
Jan 21, 2021
* Remove -ldl in agent autoconf axiom check on BSD * Move AXIOM_CHECK variable setting to system-dependent section
|
ok jenkins |
|
ok jenkins |
kneitinger
approved these changes
Jan 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR prevents an allocation error that occurs in the Drupal instrumentation and improves our logging when allocation errors do occur.
Specifically, these changes:
verbosedebugwhen the Drupal framework instrumentation problem is detected. This is consistent with the other related log messages.Supportabilitymetric in addition to the log message.The name of the
Supportabilitymetric is either:Supportability/framework/Drupal/NegativeModuleLengthorSupportability/framework/Drupal8/NegativeModuleLength. This is modeled after theMiddlewareNotCallablesupportability metric the Guzzle 6 instrumentation sends.The change to
config.m4is done to fix a build error that occurs with the addition of the calls tonr_tracer_commoninutil_memory.c(undefined reference todladdr). The reason this problem occurs now is that our test program callsnro_newfromutil_object.cwhich in turn calls functions fromutil_memory.cwhich now depend onutil_signals.cand it has a reference todladdr. Prior to this change, no symbols fromutil_signalswere needed so the linker never had to resolve thedladdrreference when building the test.The fix is to ensure that the reference to the
dllibrary occurs after the reference to theaxiomlibrary when linking. The problem is that the intuitive places to put the reference to thedllibrary are all placed before the reference toaxiom. By tacking on an-ldlto the first argument ofPHP_CHECK_LIBRARY, the library reference is placed in the appropriate place when building the lib axiom test program.