fix(agent): revert to using zend_error_cb hook for error reporting
#851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #851 +/- ##
==========================================
- Coverage 78.71% 78.70% -0.01%
==========================================
Files 193 193
Lines 27109 27109
==========================================
- Hits 21339 21337 -2
- Misses 5770 5772 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
lavarou
changed the title
zend_error_cb hook for error reporting
ZNeumann
force-pushed
the
zjn/fix-error-spam
branch
from
acac109
to
f5d8d84
Compare
zsistla
approved these changes
Mar 14, 2024
|
Could this be the cause of #872 somehow? I started observing that regression after updating from 10.13 to 10.19 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove unwanted error reporting by overwriting zend_error_cb instead of using OAPI.