Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: de-duplicate php package data #871

Merged
merged 9 commits into from
Apr 18, 2024
Merged

Conversation

bduranleau-nr
Copy link
Contributor

adds a filter for package data already sent during the current connection instance to prevent sending duplicate data between harvests.

@newrelic-php-agent-bot
Copy link

newrelic-php-agent-bot commented Apr 3, 2024

Test Suite Status Result
Multiverse 9/9 passing
SOAK 51/51 passing

@codecov-commenter
Copy link

codecov-commenter commented Apr 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.76%. Comparing base (6def121) to head (375dc80).
Report is 2 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #871   +/-   ##
=======================================
  Coverage   78.76%   78.76%           
=======================================
  Files         193      193           
  Lines       27125    27125           
=======================================
  Hits        21365    21365           
  Misses       5760     5760           
Flag Coverage Δ
agent-for-php-7.0 77.82% <ø> (ø)
agent-for-php-7.1 77.58% <ø> (ø)
agent-for-php-7.2 78.15% <ø> (ø)
agent-for-php-7.3 78.17% <ø> (ø)
agent-for-php-7.4 77.87% <ø> (ø)
agent-for-php-8.0 77.90% <ø> (ø)
agent-for-php-8.1 77.88% <ø> (ø)
agent-for-php-8.2 77.48% <ø> (ø)
agent-for-php-8.3 77.48% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bduranleau-nr bduranleau-nr marked this pull request as ready for review April 9, 2024 16:47
@zsistla zsistla requested a review from lavarou April 10, 2024 20:44
Copy link
Contributor

@mfulb mfulb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for handling this PR Brian!

@bduranleau-nr bduranleau-nr merged commit e6959a4 into dev Apr 18, 2024
62 checks passed
@bduranleau-nr bduranleau-nr deleted the fix/filter-package-data branch April 18, 2024 20:13
@lavarou lavarou added this to the next-release milestone Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants