Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

K8s sitecustomize changes #1144

Merged

Conversation

TimPansino
Copy link
Contributor

Overview

  • Add section to sitecustomize to support initializing using the K8s agents operator.
  • Refactor sitecustomize logic to fix several crashes and inconsistencies around imports.

@TimPansino TimPansino requested a review from a team May 17, 2024 00:01
@TimPansino TimPansino changed the base branch from main to develop-k8s-agent-operator May 17, 2024 00:01
Copy link

github-actions bot commented May 17, 2024

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON bandit 1 0 4.9s
✅ PYTHON black 1 0 0 0.72s
✅ PYTHON flake8 1 0 0.4s
✅ PYTHON isort 1 0 0 0.28s
✅ PYTHON pylint 1 0 2.55s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@codecov-commenter
Copy link

codecov-commenter commented May 17, 2024

Codecov Report

Attention: Patch coverage is 0% with 37 lines in your changes are missing coverage. Please review.

Please upload report for BASE (develop-k8s-agent-operator@185f6f9). Learn more about missing BASE report.

Files Patch % Lines
newrelic/bootstrap/sitecustomize.py 0.00% 37 Missing ⚠️
Additional details and impacted files
@@                      Coverage Diff                      @@
##             develop-k8s-agent-operator    #1144   +/-   ##
=============================================================
  Coverage                              ?   79.82%           
=============================================================
  Files                                 ?      192           
  Lines                                 ?    21323           
  Branches                              ?     3707           
=============================================================
  Hits                                  ?    17021           
  Misses                                ?     3242           
  Partials                              ?     1060           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hmstepanek
Copy link
Contributor

The tests are failing but it's some unrelated issue with langchain.

@TimPansino TimPansino merged commit 250ca8c into develop-k8s-agent-operator May 20, 2024
44 of 49 checks passed
@TimPansino TimPansino deleted the feature-k8s-sitecustomize-changes branch May 20, 2024 17:36
@mergify mergify bot removed the tests-failing label May 20, 2024
@umaannamalai umaannamalai added this to the v9.11.0 milestone Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants