Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Observability Pack for static websites #39

Closed
wants to merge 14 commits into from
Closed

Observability Pack for static websites #39

wants to merge 14 commits into from

Conversation

zstix
Copy link
Contributor

@zstix zstix commented May 25, 2021

Summary

Adds some basic configuration for a static site, such as one created with Gatsbyjs. This pack includes:

  • A synthetics monitor that will ping the website (with retries)
  • Alert conditions for high JS errors and low apdex
  • A troubleshooting dashboard

I took some guesses as to how we would handle variables. This was my first attempt at making a pack, I'd love some feedback!

@jpvajda
Copy link
Contributor

jpvajda commented May 27, 2021

adding to in review column so we can get this live. 🥳

Copy link
Contributor

@polfliet polfliet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great contribution Zack.
I had a few small comments and then it would be awesome to merge this pack in, thanks!

packs/static-site/alerts/apdex-low.yml Outdated Show resolved Hide resolved
packs/static-site/config.yml Outdated Show resolved Hide resolved
packs/static-site/config.yml Outdated Show resolved Hide resolved
@polfliet
Copy link
Contributor

polfliet commented Jun 3, 2021

Hi @bpeckNR! You have probably heard that we are moving to this new repository for observability packs (previously quickstarts). Here is a contribution from Zack that includes a Synthetic check and I would be great to get your review since you are our Synthetics expert! Thanks a lot!!

@zstix
Copy link
Contributor Author

zstix commented Jun 3, 2021

@polfliet I've made the requested updates. Let me know if you need anything else!

@polfliet
Copy link
Contributor

polfliet commented Jun 3, 2021

thanks @zstix !

@zstix
Copy link
Contributor Author

zstix commented Jun 3, 2021

Unfortunately, I don't think the functionality needed by this work is ready yet. More specifically, we are running into the following issues:

  • Browser alert condition types are not supported
  • NRQL field is required on alert conditions (not relevant for browser alert conditions)
  • No way to reference the static site's URL to ping (variable support)

For those reasons, this pack doesn't provide sufficient value and I'm going to close this PR. I just spun up a ticket to track the feature request for variable support (#52).

@zstix zstix closed this Jun 3, 2021
@bpeckNR
Copy link

bpeckNR commented Jun 3, 2021

Hi @bpeckNR! You have probably heard that we are moving to this new repository for observability packs (previously quickstarts). Here is a contribution from Zack that includes a Synthetic check and I would be great to get your review since you are our Synthetics expert! Thanks a lot!!

I know this PR has been closed, but I wanted to circle back on the review that was requested. It looks like the sample Synthetic monitor included a few retries but would have needed to be a scripted API monitor.

For a static site like this one, it may make sense to just use the built in Synthetics ping monitor type. While by default that uses a HEAD request, it can be configured to use a GET request and even validate the response.

As far as the retries built into the script, please note that the Synthetic environment includes 2 built in retries before a job shows up as failed.

My suggestion is to simplify this and just use a ping type OOTB Synthetics monitor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants