Prisma instrumentation #1517
Merged
Prisma instrumentation #1517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…inContext functionality works on datastore-shim
Codecov Report
@@ Coverage Diff @@
## main #1517 +/- ##
==========================================
+ Coverage 96.39% 96.41% +0.01%
==========================================
Files 196 197 +1
Lines 38198 38350 +152
Branches 23 23
==========================================
+ Hits 36822 36974 +152
Misses 1376 1376
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
jordigh
reviewed
Mar 1, 2023
jordigh
reviewed
Mar 1, 2023
jordigh
reviewed
Mar 1, 2023
| database_name: parsedUrl.path && decodeURIComponent(parsedUrl.path.split('/')[0]) | ||
| } | ||
| } catch (err) { | ||
| logger.warn('Failed to parse connection string for %s: %s', provider, err.message) |
There was a problem hiding this comment.
Is there a reason to prefer format strings over template literals?
There was a problem hiding this comment.
not really. template strings are newer and sometimes I'm just used to doing this when logging
jordigh
reviewed
Mar 1, 2023
jordigh
reviewed
Mar 1, 2023
jordigh
reviewed
Mar 1, 2023
bizob2828
commented
Mar 1, 2023
| @@ -5,7 +5,7 @@ | |||
|
|
|||
| 'use strict' | |||
|
|
|||
| /* eslint sonarjs/cognitive-complexity: ["error", 52] -- TODO: https://issues.newrelic.com/browse/NEWRELIC-5252 */ | |||
| /* eslint sonarjs/cognitive-complexity: ["error", 57] -- TODO: https://issues.newrelic.com/browse/NEWRELIC-5252 */ | |||
jordigh
approved these changes
Mar 1, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Release Notes
Huge shoutout to @osmanmrtacar for the original contribution 🙏🏻
Links
Details
You can see here the span names. It also connects the app with db.
When using
prisma.$executeRawwe will name the spans asDatastore/statement/Prisma/$executeRaw(<sql cmd>)/<database name>I also had to extend the datastore shim which I plan on writing unit tests for to take advantage of the
inContextmethod to set the params for the database host/port/db.Lastly, the original PR instrumented
_requestbut_executeRequestseems more appropriate as it's a higher level function that gets called