-
Notifications
You must be signed in to change notification settings - Fork 398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix TypeError: Object.keys called on non-object #180
Conversation
@willin Can you give reproduction cases for this? Our tests aren't failing. I can adapt the repro into a test to prove there is a problem before I merge this as I can't repro it locally. |
I have no idea about it. server.use(restify.acceptParser(server.acceptable));
server.use(restify.dateParser());
server.use(restify.queryParser());
server.use(restify.jsonp());
server.use(restify.gzipResponse());
server.use(restify.bodyParser({
mapParams: false
}));
server.get(/^\/((.*)(\.)(.+))*$/, restify.serveStatic({ directory: 'public', default: "index.html" })); When Error1 occurred, the application will auto restart, during this period, the Error2 may happen. Why check the |
stumbled upon this or similar bug when switching node binaries if that helps.
|
Prerelease versions of node are not supported. Only full release versions of 0.8 and higher are supported. That said, I'm all for trying to make our support of 0.11.x work better so we have less to do when 0.12 comes out. I've been waiting on 0.11.15 (which has a major bump to v8 versions) in it before I started testing heavily on 0.11.x. I know that we accepted a patch a week or to back that fixed on 0.11 bug in the area you are seeing problems. So make sure you're on the latest version of the agent. I'm accepted the last one because it was a very simple change and tests were 100% fine, but it appears we either didn't fix the whole problem or something else is up. In which case we need to expand our tests to be more robust and actually expose this 0.11 only bug. |
Closing this, we have made a lot of improvements since 0.12 was released, have not been able to reproduce this issue |
…/xml2js-0.5.0 Bump xml2js from 0.4.19 to 0.5.0
…/xml2js-0.5.0 Bump xml2js from 0.4.19 to 0.5.0
Bug fixed under Restify (almost the same with express.js)
Error 1:
Error 2: