Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return Hapi server object from wrappedConnection #205

Closed
wants to merge 1 commit into from

Conversation

kschat
Copy link
Contributor

@kschat kschat commented Feb 10, 2016

This was causing an issue when creating connections with Hapi.

Code to reproduce:

require('newrelic');

const Hapi = require('hapi');

const server = new Hapi.Server();
const connection = server.connection();

connection.route({/*...*/}); // Throws NPE

I didn't write any tests due to the size of the change. If you'd still like tests let me know and I'll add one.

@wraithan
Copy link
Contributor

@kschat which version of hapi were you on when you saw this issue?

@kschat
Copy link
Contributor Author

kschat commented Feb 10, 2016

Version 13. I also saw the issue with versions 12, and 9.

@martinkuba
Copy link
Contributor

@kschat if you can include a test, that would be much appreciated. Otherwise we cannot accept the PR as is.

@martinkuba
Copy link
Contributor

@kschat thanks for the fix. It has been included in v1.25.5.

@martinkuba martinkuba closed this Mar 9, 2016
bizob2828 added a commit to bizob2828/node-newrelic that referenced this pull request Apr 19, 2024
feat: updated aws sdk v3 instrumentation to function with require-in-…
bizob2828 added a commit to bizob2828/node-newrelic that referenced this pull request Apr 23, 2024
feat: updated aws sdk v3 instrumentation to function with require-in-…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants