Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Updated unit tests that were missing constructing specs at instrumentation source #2252

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

bizob2828
Copy link
Member

Description

I noticed a few unit tests were not constructing specs while doing kafkajs work. This PR updates all places where tests are using shim and to properly construct specs/params for info it passes to the shim helper method.

Copy link

codecov bot commented Jun 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.31%. Comparing base (8b1fa5d) to head (b01b05e).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2252      +/-   ##
==========================================
- Coverage   96.32%   96.31%   -0.01%     
==========================================
  Files         284      284              
  Lines       45079    45079              
==========================================
- Hits        43421    43420       -1     
- Misses       1658     1659       +1     
Flag Coverage Δ
integration-tests-16.x 50.11% <0.00%> (ø)
integration-tests-18.x 49.24% <0.00%> (ø)
integration-tests-20.x 49.25% <0.00%> (ø)
unit-tests-16.x 89.16% <0.00%> (ø)
unit-tests-18.x 89.14% <0.00%> (ø)
unit-tests-20.x 89.14% <0.00%> (ø)
versioned-tests-16.x 77.50% <100.00%> (-0.08%) ⬇️
versioned-tests-18.x 78.54% <100.00%> (-0.06%) ⬇️
versioned-tests-20.x 78.52% <100.00%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jsumners-nr jsumners-nr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants