Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove readable-stream from bundled deps? #246

Closed
wants to merge 1 commit into from
Closed

remove readable-stream from bundled deps? #246

wants to merge 1 commit into from

Conversation

mjschock
Copy link

@mjschock mjschock commented Apr 6, 2017

Hi there - i'm wondering if i might be doing something wrong on my end here (please let me know if i am!) but i wasn't able to shrinkwrap without removing the 'readable-stream' from the package.json. it would always pull in the latest 2.2.3 version rather than the expected ^1.1.13 range:

vagrant@***:/vagrant/codebases/***$ npm shrinkwrap
npm ERR! Linux 3.16.0-4-amd64
npm ERR! argv "/usr/bin/nodejs" "/usr/bin/npm" "shrinkwrap"
npm ERR! node v4.8.2
npm ERR! npm  v2.15.11

npm ERR! Problems were encountered
npm ERR! Please correct and try again.
npm ERR! invalid: readable-stream@2.2.3 /vagrant/codebases/***/node_modules/newrelic/node_modules/readable-stream
npm ERR!
npm ERR! If you need help, you may report this error at:
npm ERR!     <https://github.com/npm/npm/issues>

npm ERR! Please include the following file with any support request:
npm ERR!     /vagrant/codebases/***/npm-debug.log
vagrant@bcapp:/vagrant/codebases/***
$ npm ls readable-stream | grep newrelic -A 3
├─┬ newrelic@1.38.2
│ ├─┬ concat-stream@1.6.0
│ │ └── readable-stream@2.2.3
│ └── readable-stream@2.2.3  invalid
npm ERR! invalid: readable-stream@2.2.3 /vagrant/codebases/***/node_modules/newrelic/node_modules/readable-stream

note the invalid message

@mjschock
Copy link
Author

mjschock commented Apr 7, 2017

here's a simpler example

➜  example node -v; npm -v
v4.6.2
2.15.11
➜  example ls
➜  example npm i newrelic
newrelic@1.38.2 node_modules/newrelic
➜  example npm ls readable-stream
/Users/***/dev/example
└─┬ newrelic@1.38.2
  ├─┬ concat-stream@1.6.0
  │ └── readable-stream@2.2.3
  └── readable-stream@2.2.3  invalid

npm ERR! invalid: readable-stream@2.2.3 /Users/***/dev/example/node_modules/newrelic/node_modules/readable-stream

i'm thinking this might just be a bug in this version of npm..

@mjschock
Copy link
Author

mjschock commented Apr 7, 2017

closing as i think i can get this working with npm install --production or npm shrinkwrap --production

@mjschock mjschock closed this Apr 7, 2017
bizob2828 pushed a commit to bizob2828/node-newrelic that referenced this pull request Apr 19, 2024
bizob2828 pushed a commit to bizob2828/node-newrelic that referenced this pull request Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant