chore: updated fake agent to register ritm hooks #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrickard
previously approved these changes
Aug 16, 2023
|
We will have to wait to merge this until after we release 11.0.0 because the tests will not pass |
Codecov Report
@@ Coverage Diff @@
## main #179 +/- ##
=======================================
Coverage 77.97% 77.97%
=======================================
Files 15 15
Lines 2424 2424
=======================================
Hits 1890 1890
Misses 534 534
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
bizob2828
changed the title
bizob2828
force-pushed
the
ritm-updates
branch
from
3a8c396
to
5bc3767
Compare
mrickard
approved these changes
Aug 28, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Release Notes
shimmer.registerHooksandshimmer.removeHooksto set up instrumentation and remove it.Links
This assumes the work in newrelic/node-newrelic#1758 is merged and released.
Details
This change isn't necessary until after release of the agent because I kept those functions. Technically
shimmer.registerHooksshould now be called after bootstrapping instrumentation but it's ok for now.