feat: resolves #17 by adding support for providing additional url que… #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ry parameters on table API call
jbeveland27
reviewed
Jan 10, 2024
Comment on lines
+393
to
+398
| The `query` configuration parameter should not be confused with the | ||
| `urlQueryParameters` configuration parameter. The former is used to specify an | ||
| [encoded query string](https://docs.servicenow.com/csh?topicname=c_EncodedQueryStrings&version=utah&pubname=utah-platform-user-interface) | ||
| used to filter the ServiceNow query result set. The latter is used to specify | ||
| additional query parameters to add to the ReST API URL generated to execute the | ||
| `table` API query. |
jbeveland27
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ry parameters on table API call
Description
Support additional query parameters for the ServiceNow Provider in entity tag sync. Adds support in the CMDB provider to recognize a new
urlQueryParamsattribute and will add all key+value pairs as query parameters on the SNOWtableAPI call.Type of change
functionality to not work as expected)
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Checklist: