Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create / config an Action that validates that a submodule contains the Catalog components #1

Closed
5 tasks done
tangollama opened this issue Feb 27, 2020 · 3 comments
Closed
5 tasks done

Create / config an Action that validates that a submodule contains the Catalog components #1

tangollama opened this issue Feb 27, 2020 · 3 comments

Comments

@tangollama
Copy link
Contributor

tangollama commented Feb 27, 2020 •
edited by jbeveland27
Loading

The specs for the catalog are described in detail here and usage in the proposed UI is here.

We need:

  • a semantic version number in the package.json
  • an nr1.json file in the root of the submodule
  • an icon.png file in the root of the submodule
  • a catalog/config.json file matching the linked format (containing at least two elements in the support subsection of the JSON)
  • at least one screenshot in the catalog/screenshots directory
@jbeveland27
Copy link
Contributor

We're currently using semantic-release to handle versioning (via .releaserc). There are several GitHub Actions available to more or less do the same thing we're doing with CircleCi. Do we want to continue using that or switch to just detecting semantic version number in package.json?

This was referenced Feb 27, 2020
Closed
Closed
@jbeveland27
Copy link
Contributor

jbeveland27 commented Mar 6, 2020 •
edited
Loading

Is the icon.png needed in the root of the submodule, or the root of a launcher? If this doc is the source of truth, we might need to add icon files to all the nerdpacks for the catalog to pick them up correctly.

@jbeveland27
Copy link
Contributor

jbeveland27 commented Mar 27, 2020 •
edited
Loading

Files-present-action addresses all these requirements.

jbeveland27 added a commit that referenced this issue Apr 6, 2020
@jbeveland27
feat: add nr1-browser-analyzer submodule (#1) [skip publish]
f77d666 
* feat: add nr1-browser-analyzer submodule

* chore: changing submodule commit to trigger PR build

* chore: changing submodule commit back to latest
tangollama pushed a commit that referenced this issue Apr 24, 2020
@mmfred
Merge pull request #1 from newrelic/master
30d6317 
updating fork with changes from upstream
tangollama added a commit that referenced this issue Apr 29, 2020
@tangollama
Merge pull request #1 from newrelic/master
c5bf137 
Update from master
This was referenced May 6, 2020
Closed
Closed
Merged
This was referenced May 7, 2020
Closed
Closed
Merged
Merged
@tangollama tangollama mentioned this issue May 20, 2020
Merged
jbeveland27 pushed a commit that referenced this issue May 20, 2020
@tangollama
Merge pull request #1 from newrelic/master
548eb31 
master update
This was referenced May 20, 2020
Merged
Closed
Closed
Merged
Merged
Merged
@jake-codes jake-codes mentioned this issue Jun 2, 2020
Closed
71 tasks
This was referenced Jun 30, 2020
Closed
Closed
This was referenced Jul 9, 2020
Closed
Merged
tangollama added a commit that referenced this issue Jul 10, 2020
@tangollama
Merge pull request #1 from newrelic/master
0a3811f 
update from main
This was referenced Oct 8, 2020
Closed
Closed
Closed
Closed
@jake-codes jake-codes mentioned this issue Mar 2, 2021
Closed
71 tasks
This was referenced May 21, 2021
Merged
Merged
@Kav91 Kav91 mentioned this issue Jul 12, 2021
Closed
71 tasks
@JuliaNocera JuliaNocera mentioned this issue Aug 5, 2021
Merged
71 tasks
@shahramk shahramk mentioned this issue Dec 27, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tangollama @jbeveland27