Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create / config an Action that validates the expected structure of an NR1 application #3

Closed
10 tasks done
tangollama opened this issue Feb 27, 2020 · 1 comment
Closed
10 tasks done

Comments

@tangollama
Copy link
Contributor

tangollama commented Feb 27, 2020

There are a number of commands and configurations that we're recommending / enforcing internally w/r/t to NR1 apps w/in New Relic. We want to be sure we're validating that these configurations exist so that we have the capability to execute things like linting commands further downstream in the process.

  • README.md
  • .prettierrc.js
  • .eslintrc.js
  • .gitignore
  • .releaserc
  • package.json
  • LICENSE
  • THIRD_PARTY_NOTICES.md

In addition, the package.json should contain the following commands:

  • scripts.eslint-check
  • scripts.eslint-fix

See our current, standard circleci config as a pattern.

@tangollama tangollama changed the title Create / config an action that validates the expected structure of an NR1 application Create / config an Action that validates the expected structure of an NR1 application Feb 27, 2020
@jbeveland27
Copy link
Contributor

Files-present-action addresses all these requirements.

jbeveland27 added a commit that referenced this issue Apr 6, 2020
* feat: add nr1-browser-analyzer submodule

* feat: add nr1-cloud-optimize (#2) [skip publish]

* feat: add nr1-container-explorer submodule (#3) [skip publish]

* feat: add nr1-datalyzer submodule (#4) [skip publish]

Co-authored-by: Michael Frederick <michael.frederickjr@gmail.com>
tangollama added a commit that referenced this issue Jun 24, 2020
Update from upstream master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants