-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redesign: Apply redesign #11
Redesign: Apply redesign #11
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love the improved table @danielgolden . A few questions on using custom styles vs. just using the standard styles from the NR1 platform.
Two issues I'm noticing:
- Search performance is pretty bad. With a table of ~ 2,000 entries, there's a multi-second lag before refresh when I add or remove a character from the search bar on my 2018 Macbook Pro in Firefox.
- The agent releases table sits on top of the main table when I narrow my window below ~ 1,100 pixels.
Makes sure the update from c6fccff gets carried over
…r1-groundskeeper into feat/redesign-options-bar
We spoke about the rationale behind removing the NRDS.scss stylesheet in slack. This addresses 3 of the comments from the code review, which I have since resolved. |
Makes the nerdlet usable at small screen sizes down to ~1000px.
Looks really good! Performance is much improved and the layout bugs in Firefox are gone. I'm going to merge this. One followup request: sorting by age looks like it's an alphabetical search. Can you add a numeric sort field for that column so (e.g.) |
🎉 This PR is included in version 0.4.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Overview of changes made:
Redesign toolbar:
<select>
elements for<Dropdown>
componentsRedesign tables:
Screenshot
Resolves #3