Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor the use of PlatformStateContext, NerdletStateContext, and AutoSizer #23

Closed
2 tasks
tangollama opened this issue Mar 11, 2020 · 1 comment · Fixed by #29
Closed
2 tasks

Refactor the use of PlatformStateContext, NerdletStateContext, and AutoSizer #23

tangollama opened this issue Mar 11, 2020 · 1 comment · Fixed by #29
Assignees
@tangollama
Labels
enhancement New feature or request released

Comments

@tangollama
Copy link
Contributor

The current implementation on those components falls outside of our best practice. We need to resolve that. Look to some of the refactoring in @newrelic/nr1-browser-analyzer for patterns.

  • The objective is to make of the context states in the render method that needs that data vs. the entire Nerdlet (a workaround for the original programmability GA)
  • removing the use of AutoSizer all together if it's not needed
@tangollama tangollama added the enhancement New feature or request label Mar 11, 2020
@tangollama tangollama self-assigned this Mar 28, 2020
tangollama pushed a commit to tangollama/nr1-neon that referenced this issue Mar 28, 2020
fix: Resolves nerdlet state usage. Closes newrelic#23.
3f6473f
@tangollama tangollama mentioned this issue Mar 28, 2020
Merged
devfreddy pushed a commit that referenced this issue Mar 30, 2020
chore(release): 0.3.1 [skip ci]
5ff94e2 
## [0.3.1](v0.3.0...v0.3.1) (2020-03-30)

### Bug Fixes

* eslint upgrade closes newrelic/nr1-neon[#28](#28) ([e55146f](e55146f))
* linting issues. ([823080f](823080f))
* Resolves nerdlet state usage. Closes newrelic/nr1-neon[#23](#23). ([3f6473f](3f6473f))
@devfreddy
Copy link
Contributor

🎉 This issue has been resolved in version 0.3.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tangollama tangollama

Labels
enhancement New feature or request released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Addresses eslint upgrade and state context tangollama/nr1-neon
2 participants
@devfreddy @tangollama