Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add back support for custom attributes #30

Closed
roobre opened this issue Apr 22, 2021 · 2 comments
Closed

Add back support for custom attributes #30

roobre opened this issue Apr 22, 2021 · 2 comments
Labels
feature request Categorizes issue or PR as related to a new feature or enhancement. triage/in-progress Issue or PR is in the process of being triaged.

Comments

@roobre
Copy link
Contributor

roobre commented Apr 22, 2021 •
edited
Loading

Context

Previous to nri-docker 1.3.3, the fargate sidecar was running with the agent in NRIA_IS_SECURE_FORWARD_ONLY mode. This allowed the agent to send custom attributes as entity tags, which then infra platform used to decorate container samples. However, this mode has the side-effect of also creating an entity for the host, which is not something desired in Fargate.

With nri-docker 1.3.3 we switched to the NRIA_IS_FORWARD_ONLY mode, that does not report anything about the host. However, this also has the side-effect of the agent not decorating samples with almost anything.

There is no clear solution for this.
@roobre roobre mentioned this issue Apr 22, 2021
Closed
@roobre roobre added design Categorizes issue or PR as related to design. feature request Categorizes issue or PR as related to a new feature or enhancement. priority/pending labels Apr 22, 2021
@gsanchezgavier gsanchezgavier mentioned this issue Nov 4, 2021
Merged
@b0564914
Copy link

b0564914 commented Nov 8, 2021

@gsanchezgavier: Any timelines when this is supported?

@paologallinaharbur
Copy link
Member

Related to this PR newrelic/infrastructure-agent#825, currently merged, but not released yet

@paologallinaharbur paologallinaharbur mentioned this issue Jan 20, 2022
Closed
@davidgit davidgit added triage/in-progress Issue or PR is in the process of being triaged. and removed design Categorizes issue or PR as related to design. labels May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request Categorizes issue or PR as related to a new feature or enhancement. triage/in-progress Issue or PR is in the process of being triaged.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@davidgit @roobre @b0564914 @paologallinaharbur @nr-opensource-bot