-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update certificates and add documentation. #1064
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1064 +/- ##
=======================================
Coverage 67.94% 67.94%
=======================================
Files 55 55
Lines 3379 3379
=======================================
Hits 2296 2296
Misses 904 904
Partials 179 179 ☔ View full report in Codecov by Sentry. |
cat rootCA.pem | ||
``` | ||
|
||
Replace the contents of `rootCA.pem` with the contents of `rootCA.pem`. Do **NOT** copy the key file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please rephrase this sentence? It sounds you are replacing contents of a file with its own content, which is a noop. Also, can you explain why not simply copying the key file? There must be a good reason for that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see where the confusion can arise. I'll reword it to use copy instead of replace. Regarding the key file, the engineer needs to copy the CA cert, not the key. The CA key is the private key used to sign certs so committing that would would be bad, hence the warning. I'll clarify this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thoughts on this: Copy rootCA.pem
into src/integration/sink/testdata
replacing the expired cert. Do NOT copy rootCA-key.pem
file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So where do you store the key?
Description
Type of change
Checklist: