Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update certificates and add documentation. #1064

Merged
merged 4 commits into from
Jun 11, 2024

Conversation

dbudziwojskiNR
Copy link
Contributor

Description

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • New feature / enhancement (non-breaking change which adds functionality)
  • Security fix
  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • Add changelog entry following the contributing guide
  • Documentation has been updated
  • This change requires changes in testing:
    • unit tests
    • E2E tests

Copy link

codecov bot commented Jun 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.94%. Comparing base (24a8793) to head (34933c6).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1064   +/-   ##
=======================================
  Coverage   67.94%   67.94%           
=======================================
  Files          55       55           
  Lines        3379     3379           
=======================================
  Hits         2296     2296           
  Misses        904      904           
  Partials      179      179           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dbudziwojskiNR dbudziwojskiNR marked this pull request as ready for review June 11, 2024 18:43
@dbudziwojskiNR dbudziwojskiNR requested a review from a team June 11, 2024 18:43
.github/workflows/push_pr.yaml Show resolved Hide resolved
cat rootCA.pem
```

Replace the contents of `rootCA.pem` with the contents of `rootCA.pem`. Do **NOT** copy the key file.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please rephrase this sentence? It sounds you are replacing contents of a file with its own content, which is a noop. Also, can you explain why not simply copying the key file? There must be a good reason for that

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see where the confusion can arise. I'll reword it to use copy instead of replace. Regarding the key file, the engineer needs to copy the CA cert, not the key. The CA key is the private key used to sign certs so committing that would would be bad, hence the warning. I'll clarify this.

Copy link
Contributor Author

@dbudziwojskiNR dbudziwojskiNR Jun 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thoughts on this: Copy rootCA.pem into src/integration/sink/testdata replacing the expired cert. Do NOT copy rootCA-key.pem file.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So where do you store the key?

@dbudziwojskiNR dbudziwojskiNR merged commit 1117358 into main Jun 11, 2024
28 checks passed
@dbudziwojskiNR dbudziwojskiNR deleted the dbudziwojski/fix-expired-certificates branch June 11, 2024 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants