Fetch node status conditions and unschedulable state from API server rather than KSM #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roobre
changed the title
roobre
force-pushed
the
simpler-node-status-conditions
branch
3 times, most recently
from
d700bfb
to
c390404
Compare
roobre
changed the title
roobre
force-pushed
the
simpler-node-status-conditions
branch
from
c390404
to
2345229
Compare
invidian
reviewed
Aug 23, 2021
| continue | ||
| } | ||
|
|
||
| // Since conditions is a list, there could be duplicate conditions. Check ff we have added this condition before |
There was a problem hiding this comment.
Can the condition really be duplicate? I was not able to observe that in my tests, though I couldn't find code preventing it either.
There was a problem hiding this comment.
I believe the API should disallow that, but took the defensive programming approach here and since the input is a list, there should be possible for that to happen.
There was a problem hiding this comment.
would make sense to log when this happen? oh I see no log here
There was a problem hiding this comment.
Yup, I thought the same but definitely not worth passing a logger this deep down :(
Rumbles about global loggers
roobre
changed the title
roobre
force-pushed
the
simpler-node-status-conditions
branch
from
2345229
to
f58ddb4
Compare
gsanchezgavier
approved these changes
Aug 25, 2021
| continue | ||
| } | ||
|
|
||
| // Since conditions is a list, there could be duplicate conditions. Check ff we have added this condition before |
There was a problem hiding this comment.
would make sense to log when this happen? oh I see no log here
Signed-off-by: Mateusz Gozdek <mgozdek@microsoft.com>
Signed-off-by: Mateusz Gozdek <mgozdek@microsoft.com>
Signed-off-by: Mateusz Gozdek <mgozdek@microsoft.com>
Signed-off-by: Mateusz Gozdek <mgozdek@microsoft.com>
So metrics can be generated using API server data instead of KSM.
invidian
force-pushed
the
simpler-node-status-conditions
branch
from
f58ddb4
to
cd66ac7
Compare
roobre
commented
Aug 26, 2021
To be used for kubelet metrics. Signed-off-by: Mateusz Gozdek <mgozdek@microsoft.com>
So all transform functions are in a single file. Signed-off-by: Mateusz Gozdek <mgozdek@microsoft.com>
invidian
force-pushed
the
simpler-node-status-conditions
branch
from
cd66ac7
to
7ff306f
Compare
roobre
added a commit
that referenced
this pull request
Sep 6, 2021
…rather than KSM (#194) * src/kubelet/group_test.go: fix imports Signed-off-by: Mateusz Gozdek <mgozdek@microsoft.com> * src/kubelet/group_test.go: fix formatting Signed-off-by: Mateusz Gozdek <mgozdek@microsoft.com> * src/kubelet/metric/testdata: fix imports Signed-off-by: Mateusz Gozdek <mgozdek@microsoft.com> * src/kubelet/metric/testdata: fix comments formatting Signed-off-by: Mateusz Gozdek <mgozdek@microsoft.com> * src/kubelet/group: fetch conditions and unschedulable from API server So metrics can be generated using API server data instead of KSM. * cmd/kubernetes-static: add conditions to mocked API server * src/metric: remove node condition fetching from KSM metrics * src/kubelet/metric: add PrefixFromMapInt function To be used for kubelet metrics. Signed-off-by: Mateusz Gozdek <mgozdek@microsoft.com> * src/metric: add condition and unschedulable metrics to kubelet definitions * src/kubelet/metric: move OneMetricPerLabel to separate file So all transform functions are in a single file. Signed-off-by: Mateusz Gozdek <mgozdek@microsoft.com> Co-authored-by: Mateusz Gozdek <mgozdek@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces implementation in #155.
Previous implementation fetched this information from KSM metrics. This caused those metrics to be reported for one node by a different one on multi-node clusters, since there is only one instance of the DaemonSet fetching data for all the cluster objects. In turn, this caused some attributes to have unexpected values, such as
hostnamenot matchingnodeName.This implementation fetches this information from the local node, as an additional step to parsing data from the kubelet.
Additionally, the
unschedulablemetric is also fetched this way.