Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add k8s v1.23 & v1.24 new metrics #485

Merged
merged 10 commits into from
Jun 21, 2022
Merged

Conversation

kang-makes
Copy link
Contributor

@kang-makes kang-makes commented Jun 9, 2022

Skipping e2e because could fail as it is not in the entity definitions yet.

Metrics added to the table of the metrics we have to add to the spec files: #455

@kang-makes kang-makes added the ci/skip-e2e E2E tests will be skipped for this PR label Jun 9, 2022
@kang-makes kang-makes requested a review from a team June 9, 2022 13:07
Copy link
Contributor

@sigilioso sigilioso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@marcsanmi marcsanmi requested a review from a team June 14, 2022 13:44
@sigilioso sigilioso self-requested a review June 15, 2022 08:03
Copy link
Contributor

@sigilioso sigilioso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I've just left a comment about versions checks in tests

src/controlplane/controlplane_test.go Outdated Show resolved Hide resolved
@marcsanmi marcsanmi requested a review from a team June 16, 2022 06:55
Copy link
Member

@paologallinaharbur paologallinaharbur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

everything looks correct!

@marcsanmi marcsanmi changed the title Add inflight requests metric Add k8s v1.23 & v1.24 new metrics Jun 21, 2022
@marcsanmi marcsanmi merged commit fbd0b86 into main Jun 21, 2022
@marcsanmi marcsanmi deleted the feat/add-inflight-requests-metric branch June 21, 2022 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/skip-e2e E2E tests will be skipped for this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants