Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more workload name fields to K8sContainerSample, K8sPodSample #733

Merged
merged 5 commits into from
May 2, 2023

Conversation

htroisi
Copy link
Contributor

@htroisi htroisi commented Apr 27, 2023

Context

https://issues.newrelic.com/browse/NEWRELIC-8032

This PR adds the following fields to K8sContainerSample and K8sPodSample:

  • daemonsetName
  • replicasetName
  • jobName
  • statefulsetName

This will allow users quickly determine which containers belong to a non deployment workload.

Related PRs

Testing Plan

  • Spin up local dev environment and use the Query Builder to check for the newly added fields in K8sContainerSample and K8sPodSample.
  • Static testing passes
  • E2E testing passes - Note that for these specific metric additions, E2E testing is meaningless (e.g. cannot be used to tell us when the infra shim is in place). This is because E2E testing checks for the presence of metrics in the Metric table by looking at the keyset(). These specific metrics already exist in Metric via other event tables (e.g. K8sJobSample also pushes to k8s.jobName). So E2E testing will pass before the infra shim is in place.

Signed-off-by: Hannah Troisi <htroisi@pixielabs.ai>
Signed-off-by: Hannah Troisi <htroisi@pixielabs.ai>
@htroisi htroisi requested review from a team, philkuz and juanjjaramillo April 27, 2023 15:50
@htroisi htroisi changed the title add container metrics Add more workload name fields to K8sContainerSample Apr 27, 2023
@htroisi htroisi marked this pull request as draft April 27, 2023 17:56
Signed-off-by: Hannah Troisi <htroisi@pixielabs.ai>
@htroisi htroisi changed the title Add more workload name fields to K8sContainerSample Add more workload name fields to K8sContainerSample, K8sPodSample Apr 27, 2023
Signed-off-by: Hannah Troisi <htroisi@pixielabs.ai>
Signed-off-by: Hannah Troisi <htroisi@pixielabs.ai>
@htroisi htroisi marked this pull request as ready for review May 2, 2023 00:24
@htroisi htroisi merged commit 045788f into main May 2, 2023
@htroisi htroisi deleted the add_container_metrics branch May 2, 2023 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants