chore: Add CHANGELOG github workflow #837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svetlanabrennan
changed the title
juanjjaramillo
approved these changes
Aug 8, 2023
|
|
||
| - name: Check if CHANGELOG is valid | ||
| uses: newrelic/release-toolkit/validate-markdown@v1 | ||
|
|
There was a problem hiding this comment.
Have you tested this works as intended? Reading the documentation it looks like it only checks what has been introduced in the Unreleased section follows the right pattern. What if it is empty?
There was a problem hiding this comment.
I've tested this on one of my test personal repos. If the Unreleased section is empty then that's fine - it'll pass. It's just the L3 headers can't be empty.
There was a problem hiding this comment.
Ok, so it is still honor system
csongnr
pushed a commit
that referenced
this pull request
Nov 9, 2023
* Add changelog github workflow * fix typo * Update changelog action * undue contributing file changes * Fix lint * Update changelog.yml * Add changelog * Update changelog entry to include link
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a changelog action that valids if a PR updates a changelog by using the
newrelic/release-toolkit/validate-markdown@v1.Relates to this PR: #836