-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Add CHANGELOG github workflow #837
Conversation
|
||
- name: Check if CHANGELOG is valid | ||
uses: newrelic/release-toolkit/validate-markdown@v1 | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you tested this works as intended? Reading the documentation it looks like it only checks what has been introduced in the Unreleased section follows the right pattern. What if it is empty?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tested this on one of my test personal repos. If the Unreleased section is empty then that's fine - it'll pass. It's just the L3 headers can't be empty.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, so it is still honor system
* Add changelog github workflow * fix typo * Update changelog action * undue contributing file changes * Fix lint * Update changelog.yml * Add changelog * Update changelog entry to include link
Adding a changelog action that valids if a PR updates a changelog by using the
newrelic/release-toolkit/validate-markdown@v1
.Relates to this PR: #836