Add Failed Pod - Container Creating Test #848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juanjjaramillo
force-pushed
the
add-failed-pod-container-creating-test
branch
from
c67897b
to
13dcc67
Compare
juanjjaramillo
approved these changes
Nov 9, 2023
juanjjaramillo
force-pushed
the
add-failed-pod-container-creating-test
branch
from
13dcc67
to
69a82df
Compare
juanjjaramillo
force-pushed
the
add-failed-pod-container-creating-test
branch
from
69a82df
to
378b981
Compare
svetlanabrennan
approved these changes
Nov 10, 2023
svetlanabrennan
approved these changes
Nov 10, 2023
|
LGTM. I've also ran this nrql tests locally and they pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Add e2e nrql tests for pod dashboard for container creating.
New Tests?
Please describe the new tests that were added (if applicable).
Checklist: