Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(tests): Update unit testing data #868

Merged
merged 2 commits into from
Sep 6, 2023
Merged

feat(tests): Update unit testing data #868

merged 2 commits into from
Sep 6, 2023

Conversation

juanjjaramillo
Copy link
Contributor

Which problem is this PR solving?

Companion PR to #867

Short description of the changes

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Security fix
  • New feature / enhancement (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • This change requires a documentation update

New Tests?

Please describe the new tests that were added (if applicable).

  • This change requires changes in testing:
    • unit tests
    • e2e tests

Checklist:

  • Add changelog entry following the contributing guide
  • Tests have been added
  • Documentation has been updated

@juanjjaramillo juanjjaramillo added the ci/skip-e2e E2E tests will be skipped for this PR label Sep 6, 2023
@juanjjaramillo juanjjaramillo marked this pull request as ready for review September 6, 2023 21:00
@juanjjaramillo juanjjaramillo requested a review from a team September 6, 2023 21:00
@juanjjaramillo juanjjaramillo merged commit 784a7dc into main Sep 6, 2023
13 checks passed
@juanjjaramillo juanjjaramillo deleted the juanjjaramillo/update_test_data branch September 6, 2023 21:04
csongnr pushed a commit that referenced this pull request Nov 9, 2023
@juanjjaramillo @csongnr
feat(tests): Update unit testing data (#868)
82bf4f8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svetlanabrennan svetlanabrennan svetlanabrennan approved these changes

Assignees
No one assigned
Labels
ci/skip-e2e E2E tests will be skipped for this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@juanjjaramillo @svetlanabrennan