-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix detection of slave running for all mysql versions #89
Conversation
There were other approaches to obtain the status of the slave but as the integration already performs a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking nice overall! Left a couple questions and a few nitpicks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixes submitted
Fix detection of
slave.running
metric.With this fix we retrieve the values of
Slave_IO_Running
andSlave_SQL_Running
and if both areYes
slave.running is populated as1
or0
if any one of those 2 metrics is notYes
The metric
slave.running
provided directly by mysql, using the logic above, was removed from version 5.7 and above.