Add attribute for server port #9
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't seem to be able to add labels or reviewers. I believe this is a fairly low risk change, since I'm just adding an attribute and not modifying any existing ones. |
TylerLubeck
commented
Jan 11, 2019
| @@ -161,7 +162,11 @@ func getRawMetrics(info string) (map[string]interface{}, map[string]map[string]i | |||
| } | |||
| } else { | |||
| value := strings.TrimSuffix(parts[1], "\r\n") | |||
| metrics[parts[0]] = asValue(value) | |||
| if parts[0] == "tcp_port" { | |||
There was a problem hiding this comment.
I don't like doing this, and would love to hear suggestions on a better way. The problem seems to be that custom attributes must be strings and not numbers, and since tcp_port:6379 gets converted to a number the attribute isn't sent.
8 tasks
|
Hi @TylerLubeck we will check this and #10 thanks for the PRs and sorry for the delay. |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the changes
Hello! We run multiple instances of redis on a given machine, and differentiate between them based on their port number. This PR adds a new custom attribute with the port number to each set of metrics
PR Review Checklist
Author
Reviewer