chore(PPDSC-2780): chore/ppdse-2780-titlebar-defaults fixed defaults #605

baburay23 · 2023-02-06T14:14:18Z

PPDSC-2780

What

Background - why this is needed
What did you do-changes spaceInset to paddingBlock and paddingInline. i have not done a codemod for this as it is being done in this ticket. https://nidigitalsolutions.jira.com/browse/PPDSC-2817 is this ok?
What does the reviewers should expect

I have done:

Written unit tests against changes
Written functional tests against the component and/or NewsKit site
Updated relevant documentation

I have tested manually:

The feature's functionality is working as expected on Chrome, Firefox, Safari and Edge
The screen reader reads and flows through the elements as expected.
There are no new errors in the browser console coming from this PR.
When visual test is not added, it renders correctly on different browsers and mobile viewports (Safari, Firefox, small mobile viewport, tablet)
The Playground feature is working as expected

Before:

After:

Who should review this PR:

How to test:

pp-serviceaccount · 2023-02-06T14:21:49Z

You can preview these changes on:
Documentation Site: http://ncu-newskit-docs.s3-website-eu-west-1.amazonaws.com/ppdsc-2780-titlebar-default-styles
Storybook: http://ncu-newskit-docs.s3-website-eu-west-1.amazonaws.com/ppdsc-2780-titlebar-default-styles/storybook

Xin00163 · 2023-02-10T09:34:06Z

src/title-bar/__tests__/__snapshots__/title-bar.test.tsx.snap

@@ -930,21 +936,13 @@ exports[`TitleBar renders a title bar with logical props overrides 1`] = `
  margin-block: 32px;
  padding-inline: 8px;
  padding-block: 16px;
+  margin-inline: 48px;
+  margin-block: 32px;
+  padding-inline: 8px;


We might want to update the test so overrides are different from default but the rest looks good

mstuartf · 2023-02-10T13:12:36Z

src/title-bar/styled.tsx

 import {ContainerProps} from './types';

 export const StyledStackContainer = styled(Stack)<ContainerProps>`
-  // LOGICAL_PROPS_TO_DO: remove the below func when logical props are used in defaults
-  ${getResponsiveSpacingInset('titleBar', '')}


spaceInset is still in the overrides types, so I think we can't remove this yet.

@mutebg

@mstuartf @mutebg do you think its maybe ok to remove it from types now as well? or wait till the ticket https://nidigitalsolutions.jira.com/browse/PPDSC-2817

I think you should remove it from the types, it does not do anything anyway since you removed getResponsiveSpacingInset.
I think once you do that, you need to go over all TitleBars in doc site and change from sapceInset to padding, If you want we can try to do that via the codemod which I am working on right now so that we can test it

@mutebg i removed spaceInset from the types and I removed it from the documentation. The padding props were already in the titlebar documentation so I did not need to end up adding anything. Is this ok? I thought of using the codemod but the documentation was already there, only had to change one override in the doc site

mutebg · 2023-02-13T14:14:35Z

site/pages/components/title-bar.mdx

@@ -43,9 +43,6 @@ Title bar has a number of props to facilitate a variety of uses:
  <Prop name="overrides" type="object">
    If provided, overrides the respective presets for the component and provided
    elements.
-    <Prop name="stylePreset" type="MQ<string>">


I think you removed wrong line

* chore(PPDSC-2412): major version 7.0.1 * chore(PPDSC-2412): audio player styling changes (#592) * chore(PPDSC-2412): audio player styling changes * chore(PPDSC-2412): linting and comments * chore(PPDSC-2412): typo * chore(PPDSC-2412): typo * chore(PPDSC-2412): simplify style presets * chore(PPDSC-2412): revert typo * chore(PPDSC-2412): update snapshots * chore(PPDSC-2412): add codemod to apply all style changes * chore(PPDSC-2412): update readme * feat(PPDSC-2782): changing dividerInverse color (#613) * feat(PPDSC-2782): changing sp * feat(PPDSC-2782): add new line * feat(PPDSC-2782): updated snap * chore(PPDSC-2775): update accordion default styles (#602) * fix(PPDSC-2775): update icon styles * fix(PPDSC-2775): design review * fix(PPDSC-2775): design reviews * chore(PPDSC-2412): audio player styling changes (#592) * chore(PPDSC-2412): audio player styling changes * chore(PPDSC-2412): linting and comments * chore(PPDSC-2412): typo * chore(PPDSC-2412): typo * chore(PPDSC-2412): simplify style presets * chore(PPDSC-2412): revert typo * chore(PPDSC-2412): update snapshots * chore(PPDSC-2412): add codemod to apply all style changes * chore(PPDSC-2412): update readme * chore(PPDSC-2775): codemod for accordion * fix(PPDSC-2775): revert readme * fix(PPDSC-2775): lint and snapshots * fix(PPDSC-2775): update codemods * fix(PPDSC-2775): lint * fix(PPDSC-2775): lint * fix(PPDSC-2775): remove fontColorChange from button --------- Co-authored-by: mstuartf <mstuartflood@gmail.com> * fix(PPDSC-2779): Improve handling of OrderedList paragraph scenario (#612) * fix(PPDSC-2779): improve handling of OrderedList paragraph scenario --------- Co-authored-by: JohnTParsons <JohnTParsons> * chore(PPDSC-2723): update Slider component defaults (#606) * chore(PPDSC-2723): update Slider component defaults * chore(PPDSC-2723): remove codemod * chore(PPDSC-2723): update snapshots * chore(PPDSC-2723): remove line from readme * chore(PPDSC-2776): update Link component defaults (#614) * chore(PPDSC-2776): link updates * chore(PPDSC-2776): lint fix * feat(PPDSC-2726): update snap (#615) * chore(PPDSC-2774): update Popover component defaults (#617) * chore(PPDSC-2774): update Popover component defaults * chore(PPDSC-2774): update snapshots * chore(PPDSC-2722): update Select component defaults (#608) * chore(PPDSC-2722): update Select component defaults * chore(PPDSC-2722): update snapshots * chore(PPDSC-2722): remove codemod code * chore(PPDSC-2722): addProp util to support filtering by custom prop * chore(PPDSC-2722): fix typo * chore(PPDSC-2725): banner (#607) * chore(PPDSC-2725): banner default styling changes * chore(PPDSC-2725): vertical spacing * chore(PPDSC-2725): story update * chore(PPDSC-2725): snapshots * chore(PPDSC-2725): storybook styling * chore(PPDSC-2725): revert space inset changes * Chore/ppdsc 2778 tag default styles (#622) * chore(PPDSC-2778): updatedt tests * chore(PPDSC-2778): updatedt tests * chore(PPDSC-2778): updatedt tests-stack child * feat(PPDSC-2781): update menu defaults (#616) * feat(PPDSC-2781): update menu defaults * fix(PPDSC-2781): update menu * fix(PPDSC-2781): update docs * fix(PPDSC-2781): remove extra border-box * chore(PPDSC-2780): chore/ppdse-2780-titlebar-defaults fixed defaults (#605) * chore(PPDSC-2780): chore/ppdse-2780-titlebar-defaults fixed defaults * chore(PPDSC-2780): chore/ppdse-2780-titlebar-defaults fixed defaults * chore(PPDSC-2780): chore/ppdse-2780-titlebar-defaults-add logicap props * chore(PPDSC-2780): chore/ppdse-2780-added logical props * chore(PPDSC-2780): updatedt tests * chore(PPDSC-2780): updatedt tests-theme * chore(PPDSC-2780): updatedt tests-accsessbility * chore(PPDSC-2780): updatedt tests-site * chore(PPDSC-2780): updatedt tests for logical props * chore(PPDSC-2780): updatedt tests for LP * chore(PPDSC-2780): chore/ppdse-2780-updated types * chore(PPDSC-2780): chore/ppdse-2780-updated stories * chore(PPDSC-2780): chore/ppdse-2780-tidied * chore(PPDSC-2780): chore/ppdse-2780-tidied * chore(PPDSC-2780): chore/ppdse-2780-updated snap * chore(PPDSC-2780): chore/ppdse-2780-updated snapsshots * chore(PPDSC-2780): chore/ppdse-2780-fixed * chore(PPDSC-2780): chore/ppdse-2780-updated tests fixed merge * chore(PPDSC-2780): chore/ppdse-2780-section intro update * chore(PPDSC-2780): chore/ppdse-2780-updated select * chore(PPDSC-2780): chore/ppdse-2780-updated documentatyion * feat(PPDSC-1940): remove Link component (#624) * feat(PPDSC-1940): remove Link component * feat(PPDSC-1940): fix tests * feat(PPDSC-1940): updated gitignore --------- Co-authored-by: Vanals <marco91vanali@gmail.com> * feat(PPDSC2091): caption refactoring (#627) * feat(PPDSC-2091): remove caption-inset and refactor caption * feat(PPDSC-2091): add codemod for caption * feat(PPDSC-2091): add codemod * feat(PPDSC-2091): finish codemod * feat(PPDSC-2091): add correct spacing * feat(PPDSC-2091): update docs * feat(PPDSC-2091): formating * feat(PPDSC-2091): made generic space-inset replace fn * feat(PPDSC-2091): fix lint * feat(PPDSC-2091): rename file * feat(PPDSC-2091): fix tests * feat(PPDSC-2091): address comments * feat(PPDSC-2091): update default credit style-preset * feat(PPDSC-2091): update docs * feat(PPDSC-2422): update newskit light and dark theme tokens (#632) * feat(PPDSC-2422): update newskit light and dark theme tokens * feat(PPDSC-2422): update snapshots * feat(PPDSC-2428): Popover Tooltip AudioPlayer override name (#641) * feat(PPDSC-2428): popover tooltip audio player override name * feat(PPDSC-2428): update snapshots * chore(PPDSC-1866): remove crop config (#625) * chore(PPDSC-1866): remove crop config * chore(PPDSC-1866): switch to font metrics * chore(PPDSC-1866): fix coverage * chore(PPDSC-1866): snapshots * chore(PPDSC-1866): update snapshots * chore(PPDSC-1866): update snapshots * chore(PPDSC-1866): remove old comments * feat(PPDSC-2817): replace space inset (#642) * feat(PPDCS-2817): banner, block, card, flag, button, iconButton * feat(PPDCS-2817): menu fieldset and gridlayout * feat(PPDCS-2817): select * feat(PPDCS-2817): strucutured list * feat(PPDCS-2817): text-field * feat(PPDCS-2817): tabs * feat(PPDCS-2817): toast, video-player * feat(PPDCS-2817): tag, toast and dialog * fix(PPDCS-2817): update docs token * feat(PPDCS-2817): codemod & tests * fix(PPDCS-2817): run codemod on site * fix(PPDCS-2817): update docs types and codemod * fix(PPDCS-2817): update snapshots * feat(PPDCS-2817): split into start and end in defaults * fix(PPDCS-2817): lint * fix(PPDCS-2817): remove test.only * fix(PPDCS-2817): sidebar * feat(PPDCS-2817): Revert "feat(PPDCS-2817): split into start and end in defaults" This reverts commit d2b4541. * fix(PPDCS-2817): change logical props order * fix(PPDCS-2817): update docs * fix(PPDCS-2817): test * fix(PPDCS-2817): update more docs * fix(PPDCS-2817): address reviews * fix(PPDCS-2817): update snapshots * fix(PPDCS-2817): codemod when stylePreset is added to Block * fix(PPDCS-2817): add logical props to accordion * fix(PPDCS-2817): update name * fix(PPDCS-2817): remove logical props from accordion group * chore(PPDSC-0000): typo * chore(PPDSC-0000): snapshot fix * fix(PPDSC-0000): update tests --------- Co-authored-by: JohnTParsons <JohnTParsons> Co-authored-by: Marco Vanali <Marco91Vanali@gmail.com> Co-authored-by: Xin Wang <wangxin00163@yahoo.co.uk> Co-authored-by: JohnTParsons <JohnTParsons@users.noreply.github.com> Co-authored-by: Evgeni Nikolov <evgeni.nikolov@news.co.uk> Co-authored-by: baburay23 <54642337+baburay23@users.noreply.github.com> Co-authored-by: Stoyan Delev <stoyan.delev@news.co.uk> Co-authored-by: Stoyan Delev <mutebg@users.noreply.github.com> Co-authored-by: Michael Flood <michaelflood@Michaels-Mac-mini.local>

* chore(PPDSC-2412): major version 7.0.1 * chore(PPDSC-2412): audio player styling changes (#592) * chore(PPDSC-2412): audio player styling changes * chore(PPDSC-2412): linting and comments * chore(PPDSC-2412): typo * chore(PPDSC-2412): typo * chore(PPDSC-2412): simplify style presets * chore(PPDSC-2412): revert typo * chore(PPDSC-2412): update snapshots * chore(PPDSC-2412): add codemod to apply all style changes * chore(PPDSC-2412): update readme * feat(PPDSC-2782): changing dividerInverse color (#613) * feat(PPDSC-2782): changing sp * feat(PPDSC-2782): add new line * feat(PPDSC-2782): updated snap * chore(PPDSC-2775): update accordion default styles (#602) * fix(PPDSC-2775): update icon styles * fix(PPDSC-2775): design review * fix(PPDSC-2775): design reviews * chore(PPDSC-2412): audio player styling changes (#592) * chore(PPDSC-2412): audio player styling changes * chore(PPDSC-2412): linting and comments * chore(PPDSC-2412): typo * chore(PPDSC-2412): typo * chore(PPDSC-2412): simplify style presets * chore(PPDSC-2412): revert typo * chore(PPDSC-2412): update snapshots * chore(PPDSC-2412): add codemod to apply all style changes * chore(PPDSC-2412): update readme * chore(PPDSC-2775): codemod for accordion * fix(PPDSC-2775): revert readme * fix(PPDSC-2775): lint and snapshots * fix(PPDSC-2775): update codemods * fix(PPDSC-2775): lint * fix(PPDSC-2775): lint * fix(PPDSC-2775): remove fontColorChange from button --------- Co-authored-by: mstuartf <mstuartflood@gmail.com> * fix(PPDSC-2779): Improve handling of OrderedList paragraph scenario (#612) * fix(PPDSC-2779): improve handling of OrderedList paragraph scenario --------- Co-authored-by: JohnTParsons <JohnTParsons> * chore(PPDSC-2723): update Slider component defaults (#606) * chore(PPDSC-2723): update Slider component defaults * chore(PPDSC-2723): remove codemod * chore(PPDSC-2723): update snapshots * chore(PPDSC-2723): remove line from readme * chore(PPDSC-2776): update Link component defaults (#614) * chore(PPDSC-2776): link updates * chore(PPDSC-2776): lint fix * feat(PPDSC-2726): update snap (#615) * chore(PPDSC-2774): update Popover component defaults (#617) * chore(PPDSC-2774): update Popover component defaults * chore(PPDSC-2774): update snapshots * chore(PPDSC-2722): update Select component defaults (#608) * chore(PPDSC-2722): update Select component defaults * chore(PPDSC-2722): update snapshots * chore(PPDSC-2722): remove codemod code * chore(PPDSC-2722): addProp util to support filtering by custom prop * chore(PPDSC-2722): fix typo * chore(PPDSC-2725): banner (#607) * chore(PPDSC-2725): banner default styling changes * chore(PPDSC-2725): vertical spacing * chore(PPDSC-2725): story update * chore(PPDSC-2725): snapshots * chore(PPDSC-2725): storybook styling * chore(PPDSC-2725): revert space inset changes * Chore/ppdsc 2778 tag default styles (#622) * chore(PPDSC-2778): updatedt tests * chore(PPDSC-2778): updatedt tests * chore(PPDSC-2778): updatedt tests-stack child * feat(PPDSC-2781): update menu defaults (#616) * feat(PPDSC-2781): update menu defaults * fix(PPDSC-2781): update menu * fix(PPDSC-2781): update docs * fix(PPDSC-2781): remove extra border-box * chore(PPDSC-2780): chore/ppdse-2780-titlebar-defaults fixed defaults (#605) * chore(PPDSC-2780): chore/ppdse-2780-titlebar-defaults fixed defaults * chore(PPDSC-2780): chore/ppdse-2780-titlebar-defaults fixed defaults * chore(PPDSC-2780): chore/ppdse-2780-titlebar-defaults-add logicap props * chore(PPDSC-2780): chore/ppdse-2780-added logical props * chore(PPDSC-2780): updatedt tests * chore(PPDSC-2780): updatedt tests-theme * chore(PPDSC-2780): updatedt tests-accsessbility * chore(PPDSC-2780): updatedt tests-site * chore(PPDSC-2780): updatedt tests for logical props * chore(PPDSC-2780): updatedt tests for LP * chore(PPDSC-2780): chore/ppdse-2780-updated types * chore(PPDSC-2780): chore/ppdse-2780-updated stories * chore(PPDSC-2780): chore/ppdse-2780-tidied * chore(PPDSC-2780): chore/ppdse-2780-tidied * chore(PPDSC-2780): chore/ppdse-2780-updated snap * chore(PPDSC-2780): chore/ppdse-2780-updated snapsshots * chore(PPDSC-2780): chore/ppdse-2780-fixed * chore(PPDSC-2780): chore/ppdse-2780-updated tests fixed merge * chore(PPDSC-2780): chore/ppdse-2780-section intro update * chore(PPDSC-2780): chore/ppdse-2780-updated select * chore(PPDSC-2780): chore/ppdse-2780-updated documentatyion * feat(PPDSC-1940): remove Link component (#624) * feat(PPDSC-1940): remove Link component * feat(PPDSC-1940): fix tests * feat(PPDSC-1940): updated gitignore --------- Co-authored-by: Vanals <marco91vanali@gmail.com> * feat(PPDSC2091): caption refactoring (#627) * feat(PPDSC-2091): remove caption-inset and refactor caption * feat(PPDSC-2091): add codemod for caption * feat(PPDSC-2091): add codemod * feat(PPDSC-2091): finish codemod * feat(PPDSC-2091): add correct spacing * feat(PPDSC-2091): update docs * feat(PPDSC-2091): formating * feat(PPDSC-2091): made generic space-inset replace fn * feat(PPDSC-2091): fix lint * feat(PPDSC-2091): rename file * feat(PPDSC-2091): fix tests * feat(PPDSC-2091): address comments * feat(PPDSC-2091): update default credit style-preset * feat(PPDSC-2091): update docs * feat(PPDSC-2798): add css variables * feat(PPDSC-2798): add files * feat(PPDSC-2798): add fonts * feat(PPDSC-2798): update site snapshots * feat(PPDSC-2422): update newskit light and dark theme tokens (#632) * feat(PPDSC-2422): update newskit light and dark theme tokens * feat(PPDSC-2422): update snapshots * feat(PPDSC-2428): Popover Tooltip AudioPlayer override name (#641) * feat(PPDSC-2428): popover tooltip audio player override name * feat(PPDSC-2428): update snapshots * feat(PPDSC-2798): update docs * chore(PPDSC-1866): remove crop config (#625) * chore(PPDSC-1866): remove crop config * chore(PPDSC-1866): switch to font metrics * chore(PPDSC-1866): fix coverage * chore(PPDSC-1866): snapshots * chore(PPDSC-1866): update snapshots * chore(PPDSC-1866): update snapshots * chore(PPDSC-1866): remove old comments * feat(PPDSC-2798): fix coverage * feat(PPDSC-2798): fixing tests * feat(PPDSC-2798): fix tests * feat(PPDSC-2798): rename-var * feat(PPDSC-2798): update tests --------- Co-authored-by: JohnTParsons <JohnTParsons> Co-authored-by: mstuartf <mstuartflood@gmail.com> Co-authored-by: Marco Vanali <Marco91Vanali@gmail.com> Co-authored-by: Xin Wang <wangxin00163@yahoo.co.uk> Co-authored-by: JohnTParsons <JohnTParsons@users.noreply.github.com> Co-authored-by: Evgeni Nikolov <evgeni.nikolov@news.co.uk> Co-authored-by: baburay23 <54642337+baburay23@users.noreply.github.com>

* chore(PPDSC-2412): major version 7.0.1 * chore(PPDSC-2412): audio player styling changes (#592) * chore(PPDSC-2412): audio player styling changes * chore(PPDSC-2412): linting and comments * chore(PPDSC-2412): typo * chore(PPDSC-2412): typo * chore(PPDSC-2412): simplify style presets * chore(PPDSC-2412): revert typo * chore(PPDSC-2412): update snapshots * chore(PPDSC-2412): add codemod to apply all style changes * chore(PPDSC-2412): update readme * feat(PPDSC-2782): changing dividerInverse color (#613) * feat(PPDSC-2782): changing sp * feat(PPDSC-2782): add new line * feat(PPDSC-2782): updated snap * chore(PPDSC-2775): update accordion default styles (#602) * fix(PPDSC-2775): update icon styles * fix(PPDSC-2775): design review * fix(PPDSC-2775): design reviews * chore(PPDSC-2412): audio player styling changes (#592) * chore(PPDSC-2412): audio player styling changes * chore(PPDSC-2412): linting and comments * chore(PPDSC-2412): typo * chore(PPDSC-2412): typo * chore(PPDSC-2412): simplify style presets * chore(PPDSC-2412): revert typo * chore(PPDSC-2412): update snapshots * chore(PPDSC-2412): add codemod to apply all style changes * chore(PPDSC-2412): update readme * chore(PPDSC-2775): codemod for accordion * fix(PPDSC-2775): revert readme * fix(PPDSC-2775): lint and snapshots * fix(PPDSC-2775): update codemods * fix(PPDSC-2775): lint * fix(PPDSC-2775): lint * fix(PPDSC-2775): remove fontColorChange from button --------- Co-authored-by: mstuartf <mstuartflood@gmail.com> * fix(PPDSC-2779): Improve handling of OrderedList paragraph scenario (#612) * fix(PPDSC-2779): improve handling of OrderedList paragraph scenario --------- Co-authored-by: JohnTParsons <JohnTParsons> * chore(PPDSC-2723): update Slider component defaults (#606) * chore(PPDSC-2723): update Slider component defaults * chore(PPDSC-2723): remove codemod * chore(PPDSC-2723): update snapshots * chore(PPDSC-2723): remove line from readme * chore(PPDSC-2776): update Link component defaults (#614) * chore(PPDSC-2776): link updates * chore(PPDSC-2776): lint fix * feat(PPDSC-2726): update snap (#615) * chore(PPDSC-2774): update Popover component defaults (#617) * chore(PPDSC-2774): update Popover component defaults * chore(PPDSC-2774): update snapshots * chore(PPDSC-2722): update Select component defaults (#608) * chore(PPDSC-2722): update Select component defaults * chore(PPDSC-2722): update snapshots * chore(PPDSC-2722): remove codemod code * chore(PPDSC-2722): addProp util to support filtering by custom prop * chore(PPDSC-2722): fix typo * chore(PPDSC-2725): banner (#607) * chore(PPDSC-2725): banner default styling changes * chore(PPDSC-2725): vertical spacing * chore(PPDSC-2725): story update * chore(PPDSC-2725): snapshots * chore(PPDSC-2725): storybook styling * chore(PPDSC-2725): revert space inset changes * Chore/ppdsc 2778 tag default styles (#622) * chore(PPDSC-2778): updatedt tests * chore(PPDSC-2778): updatedt tests * chore(PPDSC-2778): updatedt tests-stack child * feat(PPDSC-2781): update menu defaults (#616) * feat(PPDSC-2781): update menu defaults * fix(PPDSC-2781): update menu * fix(PPDSC-2781): update docs * fix(PPDSC-2781): remove extra border-box * chore(PPDSC-2780): chore/ppdse-2780-titlebar-defaults fixed defaults (#605) * chore(PPDSC-2780): chore/ppdse-2780-titlebar-defaults fixed defaults * chore(PPDSC-2780): chore/ppdse-2780-titlebar-defaults fixed defaults * chore(PPDSC-2780): chore/ppdse-2780-titlebar-defaults-add logicap props * chore(PPDSC-2780): chore/ppdse-2780-added logical props * chore(PPDSC-2780): updatedt tests * chore(PPDSC-2780): updatedt tests-theme * chore(PPDSC-2780): updatedt tests-accsessbility * chore(PPDSC-2780): updatedt tests-site * chore(PPDSC-2780): updatedt tests for logical props * chore(PPDSC-2780): updatedt tests for LP * chore(PPDSC-2780): chore/ppdse-2780-updated types * chore(PPDSC-2780): chore/ppdse-2780-updated stories * chore(PPDSC-2780): chore/ppdse-2780-tidied * chore(PPDSC-2780): chore/ppdse-2780-tidied * chore(PPDSC-2780): chore/ppdse-2780-updated snap * chore(PPDSC-2780): chore/ppdse-2780-updated snapsshots * chore(PPDSC-2780): chore/ppdse-2780-fixed * chore(PPDSC-2780): chore/ppdse-2780-updated tests fixed merge * chore(PPDSC-2780): chore/ppdse-2780-section intro update * chore(PPDSC-2780): chore/ppdse-2780-updated select * chore(PPDSC-2780): chore/ppdse-2780-updated documentatyion * feat(PPDSC-1940): remove Link component (#624) * feat(PPDSC-1940): remove Link component * feat(PPDSC-1940): fix tests * feat(PPDSC-1940): updated gitignore --------- Co-authored-by: Vanals <marco91vanali@gmail.com> * feat(PPDSC2091): caption refactoring (#627) * feat(PPDSC-2091): remove caption-inset and refactor caption * feat(PPDSC-2091): add codemod for caption * feat(PPDSC-2091): add codemod * feat(PPDSC-2091): finish codemod * feat(PPDSC-2091): add correct spacing * feat(PPDSC-2091): update docs * feat(PPDSC-2091): formating * feat(PPDSC-2091): made generic space-inset replace fn * feat(PPDSC-2091): fix lint * feat(PPDSC-2091): rename file * feat(PPDSC-2091): fix tests * feat(PPDSC-2091): address comments * feat(PPDSC-2091): update default credit style-preset * feat(PPDSC-2091): update docs * feat(PPDSC-2422): update newskit light and dark theme tokens (#632) * feat(PPDSC-2422): update newskit light and dark theme tokens * feat(PPDSC-2422): update snapshots * feat(PPDSC-2428): Popover Tooltip AudioPlayer override name (#641) * feat(PPDSC-2428): popover tooltip audio player override name * feat(PPDSC-2428): update snapshots * chore(PPDSC-1866): remove crop config (#625) * chore(PPDSC-1866): remove crop config * chore(PPDSC-1866): switch to font metrics * chore(PPDSC-1866): fix coverage * chore(PPDSC-1866): snapshots * chore(PPDSC-1866): update snapshots * chore(PPDSC-1866): update snapshots * chore(PPDSC-1866): remove old comments * feat(PPDSC-2817): replace space inset (#642) * feat(PPDCS-2817): banner, block, card, flag, button, iconButton * feat(PPDCS-2817): menu fieldset and gridlayout * feat(PPDCS-2817): select * feat(PPDCS-2817): strucutured list * feat(PPDCS-2817): text-field * feat(PPDCS-2817): tabs * feat(PPDCS-2817): toast, video-player * feat(PPDCS-2817): tag, toast and dialog * fix(PPDCS-2817): update docs token * feat(PPDCS-2817): codemod & tests * fix(PPDCS-2817): run codemod on site * fix(PPDCS-2817): update docs types and codemod * fix(PPDCS-2817): update snapshots * feat(PPDCS-2817): split into start and end in defaults * fix(PPDCS-2817): lint * fix(PPDCS-2817): remove test.only * fix(PPDCS-2817): sidebar * feat(PPDCS-2817): Revert "feat(PPDCS-2817): split into start and end in defaults" This reverts commit d2b4541. * fix(PPDCS-2817): change logical props order * fix(PPDCS-2817): update docs * fix(PPDCS-2817): test * fix(PPDCS-2817): update more docs * fix(PPDCS-2817): address reviews * fix(PPDCS-2817): update snapshots * fix(PPDCS-2817): codemod when stylePreset is added to Block * fix(PPDCS-2817): add logical props to accordion * fix(PPDCS-2817): update name * fix(PPDCS-2817): remove logical props from accordion group * chore(PPDSC-0000): typo * chore(PPDSC-0000): snapshot fix * fix(PPDSC-0000): update tests --------- Co-authored-by: JohnTParsons <JohnTParsons> Co-authored-by: Marco Vanali <Marco91Vanali@gmail.com> Co-authored-by: Xin Wang <wangxin00163@yahoo.co.uk> Co-authored-by: JohnTParsons <JohnTParsons@users.noreply.github.com> Co-authored-by: Evgeni Nikolov <evgeni.nikolov@news.co.uk> Co-authored-by: baburay23 <54642337+baburay23@users.noreply.github.com> Co-authored-by: Stoyan Delev <stoyan.delev@news.co.uk> Co-authored-by: Stoyan Delev <mutebg@users.noreply.github.com> Co-authored-by: Michael Flood <michaelflood@Michaels-Mac-mini.local>

* chore(PPDSC-2412): major version 7.0.1 * chore(PPDSC-2412): audio player styling changes (#592) * chore(PPDSC-2412): audio player styling changes * chore(PPDSC-2412): linting and comments * chore(PPDSC-2412): typo * chore(PPDSC-2412): typo * chore(PPDSC-2412): simplify style presets * chore(PPDSC-2412): revert typo * chore(PPDSC-2412): update snapshots * chore(PPDSC-2412): add codemod to apply all style changes * chore(PPDSC-2412): update readme * feat(PPDSC-2782): changing dividerInverse color (#613) * feat(PPDSC-2782): changing sp * feat(PPDSC-2782): add new line * feat(PPDSC-2782): updated snap * chore(PPDSC-2775): update accordion default styles (#602) * fix(PPDSC-2775): update icon styles * fix(PPDSC-2775): design review * fix(PPDSC-2775): design reviews * chore(PPDSC-2412): audio player styling changes (#592) * chore(PPDSC-2412): audio player styling changes * chore(PPDSC-2412): linting and comments * chore(PPDSC-2412): typo * chore(PPDSC-2412): typo * chore(PPDSC-2412): simplify style presets * chore(PPDSC-2412): revert typo * chore(PPDSC-2412): update snapshots * chore(PPDSC-2412): add codemod to apply all style changes * chore(PPDSC-2412): update readme * chore(PPDSC-2775): codemod for accordion * fix(PPDSC-2775): revert readme * fix(PPDSC-2775): lint and snapshots * fix(PPDSC-2775): update codemods * fix(PPDSC-2775): lint * fix(PPDSC-2775): lint * fix(PPDSC-2775): remove fontColorChange from button --------- Co-authored-by: mstuartf <mstuartflood@gmail.com> * fix(PPDSC-2779): Improve handling of OrderedList paragraph scenario (#612) * fix(PPDSC-2779): improve handling of OrderedList paragraph scenario --------- Co-authored-by: JohnTParsons <JohnTParsons> * chore(PPDSC-2723): update Slider component defaults (#606) * chore(PPDSC-2723): update Slider component defaults * chore(PPDSC-2723): remove codemod * chore(PPDSC-2723): update snapshots * chore(PPDSC-2723): remove line from readme * chore(PPDSC-2776): update Link component defaults (#614) * chore(PPDSC-2776): link updates * chore(PPDSC-2776): lint fix * feat(PPDSC-2726): update snap (#615) * chore(PPDSC-2774): update Popover component defaults (#617) * chore(PPDSC-2774): update Popover component defaults * chore(PPDSC-2774): update snapshots * chore(PPDSC-2722): update Select component defaults (#608) * chore(PPDSC-2722): update Select component defaults * chore(PPDSC-2722): update snapshots * chore(PPDSC-2722): remove codemod code * chore(PPDSC-2722): addProp util to support filtering by custom prop * chore(PPDSC-2722): fix typo * chore(PPDSC-2725): banner (#607) * chore(PPDSC-2725): banner default styling changes * chore(PPDSC-2725): vertical spacing * chore(PPDSC-2725): story update * chore(PPDSC-2725): snapshots * chore(PPDSC-2725): storybook styling * chore(PPDSC-2725): revert space inset changes * Chore/ppdsc 2778 tag default styles (#622) * chore(PPDSC-2778): updatedt tests * chore(PPDSC-2778): updatedt tests * chore(PPDSC-2778): updatedt tests-stack child * feat(PPDSC-2781): update menu defaults (#616) * feat(PPDSC-2781): update menu defaults * fix(PPDSC-2781): update menu * fix(PPDSC-2781): update docs * fix(PPDSC-2781): remove extra border-box * chore(PPDSC-2780): chore/ppdse-2780-titlebar-defaults fixed defaults (#605) * chore(PPDSC-2780): chore/ppdse-2780-titlebar-defaults fixed defaults * chore(PPDSC-2780): chore/ppdse-2780-titlebar-defaults fixed defaults * chore(PPDSC-2780): chore/ppdse-2780-titlebar-defaults-add logicap props * chore(PPDSC-2780): chore/ppdse-2780-added logical props * chore(PPDSC-2780): updatedt tests * chore(PPDSC-2780): updatedt tests-theme * chore(PPDSC-2780): updatedt tests-accsessbility * chore(PPDSC-2780): updatedt tests-site * chore(PPDSC-2780): updatedt tests for logical props * chore(PPDSC-2780): updatedt tests for LP * chore(PPDSC-2780): chore/ppdse-2780-updated types * chore(PPDSC-2780): chore/ppdse-2780-updated stories * chore(PPDSC-2780): chore/ppdse-2780-tidied * chore(PPDSC-2780): chore/ppdse-2780-tidied * chore(PPDSC-2780): chore/ppdse-2780-updated snap * chore(PPDSC-2780): chore/ppdse-2780-updated snapsshots * chore(PPDSC-2780): chore/ppdse-2780-fixed * chore(PPDSC-2780): chore/ppdse-2780-updated tests fixed merge * chore(PPDSC-2780): chore/ppdse-2780-section intro update * chore(PPDSC-2780): chore/ppdse-2780-updated select * chore(PPDSC-2780): chore/ppdse-2780-updated documentatyion * feat(PPDSC-1940): remove Link component (#624) * feat(PPDSC-1940): remove Link component * feat(PPDSC-1940): fix tests * feat(PPDSC-1940): updated gitignore --------- Co-authored-by: Vanals <marco91vanali@gmail.com> * feat(PPDSC2091): caption refactoring (#627) * feat(PPDSC-2091): remove caption-inset and refactor caption * feat(PPDSC-2091): add codemod for caption * feat(PPDSC-2091): add codemod * feat(PPDSC-2091): finish codemod * feat(PPDSC-2091): add correct spacing * feat(PPDSC-2091): update docs * feat(PPDSC-2091): formating * feat(PPDSC-2091): made generic space-inset replace fn * feat(PPDSC-2091): fix lint * feat(PPDSC-2091): rename file * feat(PPDSC-2091): fix tests * feat(PPDSC-2091): address comments * feat(PPDSC-2091): update default credit style-preset * feat(PPDSC-2091): update docs * feat(PPDSC-2798): add css variables * feat(PPDSC-2798): add files * feat(PPDSC-2798): add fonts * feat(PPDSC-2798): update site snapshots * feat(PPDSC-2422): update newskit light and dark theme tokens (#632) * feat(PPDSC-2422): update newskit light and dark theme tokens * feat(PPDSC-2422): update snapshots * feat(PPDSC-2428): Popover Tooltip AudioPlayer override name (#641) * feat(PPDSC-2428): popover tooltip audio player override name * feat(PPDSC-2428): update snapshots * feat(PPDSC-2798): update docs * chore(PPDSC-1866): remove crop config (#625) * chore(PPDSC-1866): remove crop config * chore(PPDSC-1866): switch to font metrics * chore(PPDSC-1866): fix coverage * chore(PPDSC-1866): snapshots * chore(PPDSC-1866): update snapshots * chore(PPDSC-1866): update snapshots * chore(PPDSC-1866): remove old comments * feat(PPDSC-2798): fix coverage * feat(PPDSC-2798): fixing tests * feat(PPDSC-2798): fix tests * feat(PPDSC-2798): rename-var * feat(PPDSC-2798): update tests --------- Co-authored-by: JohnTParsons <JohnTParsons> Co-authored-by: mstuartf <mstuartflood@gmail.com> Co-authored-by: Marco Vanali <Marco91Vanali@gmail.com> Co-authored-by: Xin Wang <wangxin00163@yahoo.co.uk> Co-authored-by: JohnTParsons <JohnTParsons@users.noreply.github.com> Co-authored-by: Evgeni Nikolov <evgeni.nikolov@news.co.uk> Co-authored-by: baburay23 <54642337+baburay23@users.noreply.github.com>

chore(PPDSC-2780): chore/ppdse-2780-titlebar-defaults fixed defaults

8a45629

baburay23 requested a review from a team as a code owner February 6, 2023 14:14

chore(PPDSC-2780): chore/ppdse-2780-titlebar-defaults fixed defaults

bfc4e90

baburay23 added 8 commits February 6, 2023 15:34

chore(PPDSC-2780): chore/ppdse-2780-titlebar-defaults fixed defaults

7886e1a

chore(PPDSC-2780): chore/ppdse-2780-titlebar-defaults-add logicap props

943a7b5

chore(PPDSC-2780): chore/ppdse-2780-added logical props

b043e8c

chore(PPDSC-2780): updatedt tests

f0c9a24

chore(PPDSC-2780): updatedt tests-theme

9a8d679

chore(PPDSC-2780): updatedt tests-accsessbility

2e6fc7c

chore(PPDSC-2780): updatedt tests-accsessbility

3163b6f

chore(PPDSC-2780): updatedt tests-site

750737a

baburay23 added ready for review Please assist in getting this reviewed breaking change labels Feb 9, 2023

Xin00163 reviewed Feb 10, 2023

View reviewed changes

Xin00163 approved these changes Feb 10, 2023

View reviewed changes

baburay23 added 2 commits February 10, 2023 11:10

chore(PPDSC-2780): updatedt tests for logical props

3234a89

chore(PPDSC-2780): updatedt tests for LP

0ce8025

mstuartf reviewed Feb 10, 2023

View reviewed changes

baburay23 added 11 commits February 13, 2023 11:22

chore(PPDSC-2780): chore/ppdse-2780-updated types

35144e3

chore(PPDSC-2780): chore/ppdse-2780-updated stories

9d03b97

chore(PPDSC-2780): chore/ppdse-2780-tidied

6b30d00

chore(PPDSC-2780): chore/ppdse-2780-tidied

2482f43

chore(PPDSC-2780): chore/ppdse-2780-updated snap

b8379af

chore(PPDSC-2780): chore/ppdse-2780-updated snapsshots

43aac4a

chore(PPDSC-2780): chore/ppdse-2780-sorted merge

335123e

chore(PPDSC-2780): chore/ppdse-2780-fixed

999f840

chore(PPDSC-2780): chore/ppdse-2780-updated tests fixed merge

c2926c6

chore(PPDSC-2780): chore/ppdse-2780-section intro update

b9bde22

chore(PPDSC-2780): chore/ppdse-2780-updated select

ff44f51

mutebg reviewed Feb 13, 2023

View reviewed changes

chore(PPDSC-2780): chore/ppdse-2780-updated documentatyion

aca0116

mutebg approved these changes Feb 13, 2023

View reviewed changes

baburay23 merged commit d2b137a into v7-breaking-changes Feb 13, 2023

baburay23 deleted the chore/PPDSC-2780-titlebar-default-styles branch February 13, 2023 16:00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(PPDSC-2780): chore/ppdse-2780-titlebar-defaults fixed defaults #605

chore(PPDSC-2780): chore/ppdse-2780-titlebar-defaults fixed defaults #605

baburay23 commented Feb 6, 2023 •

edited

pp-serviceaccount commented Feb 6, 2023

Xin00163 Feb 10, 2023

mstuartf Feb 10, 2023

baburay23 Feb 10, 2023

mutebg Feb 13, 2023 •

edited

baburay23 Feb 13, 2023 •

edited

mutebg Feb 13, 2023

chore(PPDSC-2780): chore/ppdse-2780-titlebar-defaults fixed defaults #605

chore(PPDSC-2780): chore/ppdse-2780-titlebar-defaults fixed defaults #605

Conversation

baburay23 commented Feb 6, 2023 • edited

pp-serviceaccount commented Feb 6, 2023

Xin00163 Feb 10, 2023

Choose a reason for hiding this comment

mstuartf Feb 10, 2023

Choose a reason for hiding this comment

baburay23 Feb 10, 2023

Choose a reason for hiding this comment

mutebg Feb 13, 2023 • edited

Choose a reason for hiding this comment

baburay23 Feb 13, 2023 • edited

Choose a reason for hiding this comment

mutebg Feb 13, 2023

Choose a reason for hiding this comment

baburay23 commented Feb 6, 2023 •

edited

mutebg Feb 13, 2023 •

edited

baburay23 Feb 13, 2023 •

edited