-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(PPDSC2091): caption refactoring #627
Conversation
You can preview these changes on: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"The caption can be inset with increased spacing. There are two sizes of inset: XS and MD." This probably needs an update.
I think we can remove spaceInset
in types.ts. What do you think? The ticket I am working on will remove for other components.
@@ -0,0 +1,133 @@ | |||
const {isObject} = require('lodash'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we use the isObject
fun from utils/helper?
Save us from installing lodash
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I forgot to update the types.
Also removed the lodash for now.
Thanks
lib/codemod/package.json
Outdated
@@ -22,6 +22,7 @@ | |||
"glob": "^8.0.3", | |||
"jscodeshift": "^0.13.1", | |||
"jscodeshift-add-imports": "^1.0.10", | |||
"lodash": "^4.17.21", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be in devDependencies?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed it. its not needed for now
* chore(PPDSC-2412): major version 7.0.1 * chore(PPDSC-2412): audio player styling changes (#592) * chore(PPDSC-2412): audio player styling changes * chore(PPDSC-2412): linting and comments * chore(PPDSC-2412): typo * chore(PPDSC-2412): typo * chore(PPDSC-2412): simplify style presets * chore(PPDSC-2412): revert typo * chore(PPDSC-2412): update snapshots * chore(PPDSC-2412): add codemod to apply all style changes * chore(PPDSC-2412): update readme * feat(PPDSC-2782): changing dividerInverse color (#613) * feat(PPDSC-2782): changing sp * feat(PPDSC-2782): add new line * feat(PPDSC-2782): updated snap * chore(PPDSC-2775): update accordion default styles (#602) * fix(PPDSC-2775): update icon styles * fix(PPDSC-2775): design review * fix(PPDSC-2775): design reviews * chore(PPDSC-2412): audio player styling changes (#592) * chore(PPDSC-2412): audio player styling changes * chore(PPDSC-2412): linting and comments * chore(PPDSC-2412): typo * chore(PPDSC-2412): typo * chore(PPDSC-2412): simplify style presets * chore(PPDSC-2412): revert typo * chore(PPDSC-2412): update snapshots * chore(PPDSC-2412): add codemod to apply all style changes * chore(PPDSC-2412): update readme * chore(PPDSC-2775): codemod for accordion * fix(PPDSC-2775): revert readme * fix(PPDSC-2775): lint and snapshots * fix(PPDSC-2775): update codemods * fix(PPDSC-2775): lint * fix(PPDSC-2775): lint * fix(PPDSC-2775): remove fontColorChange from button --------- Co-authored-by: mstuartf <mstuartflood@gmail.com> * fix(PPDSC-2779): Improve handling of OrderedList paragraph scenario (#612) * fix(PPDSC-2779): improve handling of OrderedList paragraph scenario --------- Co-authored-by: JohnTParsons <JohnTParsons> * chore(PPDSC-2723): update Slider component defaults (#606) * chore(PPDSC-2723): update Slider component defaults * chore(PPDSC-2723): remove codemod * chore(PPDSC-2723): update snapshots * chore(PPDSC-2723): remove line from readme * chore(PPDSC-2776): update Link component defaults (#614) * chore(PPDSC-2776): link updates * chore(PPDSC-2776): lint fix * feat(PPDSC-2726): update snap (#615) * chore(PPDSC-2774): update Popover component defaults (#617) * chore(PPDSC-2774): update Popover component defaults * chore(PPDSC-2774): update snapshots * chore(PPDSC-2722): update Select component defaults (#608) * chore(PPDSC-2722): update Select component defaults * chore(PPDSC-2722): update snapshots * chore(PPDSC-2722): remove codemod code * chore(PPDSC-2722): addProp util to support filtering by custom prop * chore(PPDSC-2722): fix typo * chore(PPDSC-2725): banner (#607) * chore(PPDSC-2725): banner default styling changes * chore(PPDSC-2725): vertical spacing * chore(PPDSC-2725): story update * chore(PPDSC-2725): snapshots * chore(PPDSC-2725): storybook styling * chore(PPDSC-2725): revert space inset changes * Chore/ppdsc 2778 tag default styles (#622) * chore(PPDSC-2778): updatedt tests * chore(PPDSC-2778): updatedt tests * chore(PPDSC-2778): updatedt tests-stack child * feat(PPDSC-2781): update menu defaults (#616) * feat(PPDSC-2781): update menu defaults * fix(PPDSC-2781): update menu * fix(PPDSC-2781): update docs * fix(PPDSC-2781): remove extra border-box * chore(PPDSC-2780): chore/ppdse-2780-titlebar-defaults fixed defaults (#605) * chore(PPDSC-2780): chore/ppdse-2780-titlebar-defaults fixed defaults * chore(PPDSC-2780): chore/ppdse-2780-titlebar-defaults fixed defaults * chore(PPDSC-2780): chore/ppdse-2780-titlebar-defaults-add logicap props * chore(PPDSC-2780): chore/ppdse-2780-added logical props * chore(PPDSC-2780): updatedt tests * chore(PPDSC-2780): updatedt tests-theme * chore(PPDSC-2780): updatedt tests-accsessbility * chore(PPDSC-2780): updatedt tests-site * chore(PPDSC-2780): updatedt tests for logical props * chore(PPDSC-2780): updatedt tests for LP * chore(PPDSC-2780): chore/ppdse-2780-updated types * chore(PPDSC-2780): chore/ppdse-2780-updated stories * chore(PPDSC-2780): chore/ppdse-2780-tidied * chore(PPDSC-2780): chore/ppdse-2780-tidied * chore(PPDSC-2780): chore/ppdse-2780-updated snap * chore(PPDSC-2780): chore/ppdse-2780-updated snapsshots * chore(PPDSC-2780): chore/ppdse-2780-fixed * chore(PPDSC-2780): chore/ppdse-2780-updated tests fixed merge * chore(PPDSC-2780): chore/ppdse-2780-section intro update * chore(PPDSC-2780): chore/ppdse-2780-updated select * chore(PPDSC-2780): chore/ppdse-2780-updated documentatyion * feat(PPDSC-1940): remove Link component (#624) * feat(PPDSC-1940): remove Link component * feat(PPDSC-1940): fix tests * feat(PPDSC-1940): updated gitignore --------- Co-authored-by: Vanals <marco91vanali@gmail.com> * feat(PPDSC2091): caption refactoring (#627) * feat(PPDSC-2091): remove caption-inset and refactor caption * feat(PPDSC-2091): add codemod for caption * feat(PPDSC-2091): add codemod * feat(PPDSC-2091): finish codemod * feat(PPDSC-2091): add correct spacing * feat(PPDSC-2091): update docs * feat(PPDSC-2091): formating * feat(PPDSC-2091): made generic space-inset replace fn * feat(PPDSC-2091): fix lint * feat(PPDSC-2091): rename file * feat(PPDSC-2091): fix tests * feat(PPDSC-2091): address comments * feat(PPDSC-2091): update default credit style-preset * feat(PPDSC-2091): update docs * feat(PPDSC-2422): update newskit light and dark theme tokens (#632) * feat(PPDSC-2422): update newskit light and dark theme tokens * feat(PPDSC-2422): update snapshots * feat(PPDSC-2428): Popover Tooltip AudioPlayer override name (#641) * feat(PPDSC-2428): popover tooltip audio player override name * feat(PPDSC-2428): update snapshots * chore(PPDSC-1866): remove crop config (#625) * chore(PPDSC-1866): remove crop config * chore(PPDSC-1866): switch to font metrics * chore(PPDSC-1866): fix coverage * chore(PPDSC-1866): snapshots * chore(PPDSC-1866): update snapshots * chore(PPDSC-1866): update snapshots * chore(PPDSC-1866): remove old comments * feat(PPDSC-2817): replace space inset (#642) * feat(PPDCS-2817): banner, block, card, flag, button, iconButton * feat(PPDCS-2817): menu fieldset and gridlayout * feat(PPDCS-2817): select * feat(PPDCS-2817): strucutured list * feat(PPDCS-2817): text-field * feat(PPDCS-2817): tabs * feat(PPDCS-2817): toast, video-player * feat(PPDCS-2817): tag, toast and dialog * fix(PPDCS-2817): update docs token * feat(PPDCS-2817): codemod & tests * fix(PPDCS-2817): run codemod on site * fix(PPDCS-2817): update docs types and codemod * fix(PPDCS-2817): update snapshots * feat(PPDCS-2817): split into start and end in defaults * fix(PPDCS-2817): lint * fix(PPDCS-2817): remove test.only * fix(PPDCS-2817): sidebar * feat(PPDCS-2817): Revert "feat(PPDCS-2817): split into start and end in defaults" This reverts commit d2b4541. * fix(PPDCS-2817): change logical props order * fix(PPDCS-2817): update docs * fix(PPDCS-2817): test * fix(PPDCS-2817): update more docs * fix(PPDCS-2817): address reviews * fix(PPDCS-2817): update snapshots * fix(PPDCS-2817): codemod when stylePreset is added to Block * fix(PPDCS-2817): add logical props to accordion * fix(PPDCS-2817): update name * fix(PPDCS-2817): remove logical props from accordion group * chore(PPDSC-0000): typo * chore(PPDSC-0000): snapshot fix * fix(PPDSC-0000): update tests --------- Co-authored-by: JohnTParsons <JohnTParsons> Co-authored-by: Marco Vanali <Marco91Vanali@gmail.com> Co-authored-by: Xin Wang <wangxin00163@yahoo.co.uk> Co-authored-by: JohnTParsons <JohnTParsons@users.noreply.github.com> Co-authored-by: Evgeni Nikolov <evgeni.nikolov@news.co.uk> Co-authored-by: baburay23 <54642337+baburay23@users.noreply.github.com> Co-authored-by: Stoyan Delev <stoyan.delev@news.co.uk> Co-authored-by: Stoyan Delev <mutebg@users.noreply.github.com> Co-authored-by: Michael Flood <michaelflood@Michaels-Mac-mini.local>
* chore(PPDSC-2412): major version 7.0.1 * chore(PPDSC-2412): audio player styling changes (#592) * chore(PPDSC-2412): audio player styling changes * chore(PPDSC-2412): linting and comments * chore(PPDSC-2412): typo * chore(PPDSC-2412): typo * chore(PPDSC-2412): simplify style presets * chore(PPDSC-2412): revert typo * chore(PPDSC-2412): update snapshots * chore(PPDSC-2412): add codemod to apply all style changes * chore(PPDSC-2412): update readme * feat(PPDSC-2782): changing dividerInverse color (#613) * feat(PPDSC-2782): changing sp * feat(PPDSC-2782): add new line * feat(PPDSC-2782): updated snap * chore(PPDSC-2775): update accordion default styles (#602) * fix(PPDSC-2775): update icon styles * fix(PPDSC-2775): design review * fix(PPDSC-2775): design reviews * chore(PPDSC-2412): audio player styling changes (#592) * chore(PPDSC-2412): audio player styling changes * chore(PPDSC-2412): linting and comments * chore(PPDSC-2412): typo * chore(PPDSC-2412): typo * chore(PPDSC-2412): simplify style presets * chore(PPDSC-2412): revert typo * chore(PPDSC-2412): update snapshots * chore(PPDSC-2412): add codemod to apply all style changes * chore(PPDSC-2412): update readme * chore(PPDSC-2775): codemod for accordion * fix(PPDSC-2775): revert readme * fix(PPDSC-2775): lint and snapshots * fix(PPDSC-2775): update codemods * fix(PPDSC-2775): lint * fix(PPDSC-2775): lint * fix(PPDSC-2775): remove fontColorChange from button --------- Co-authored-by: mstuartf <mstuartflood@gmail.com> * fix(PPDSC-2779): Improve handling of OrderedList paragraph scenario (#612) * fix(PPDSC-2779): improve handling of OrderedList paragraph scenario --------- Co-authored-by: JohnTParsons <JohnTParsons> * chore(PPDSC-2723): update Slider component defaults (#606) * chore(PPDSC-2723): update Slider component defaults * chore(PPDSC-2723): remove codemod * chore(PPDSC-2723): update snapshots * chore(PPDSC-2723): remove line from readme * chore(PPDSC-2776): update Link component defaults (#614) * chore(PPDSC-2776): link updates * chore(PPDSC-2776): lint fix * feat(PPDSC-2726): update snap (#615) * chore(PPDSC-2774): update Popover component defaults (#617) * chore(PPDSC-2774): update Popover component defaults * chore(PPDSC-2774): update snapshots * chore(PPDSC-2722): update Select component defaults (#608) * chore(PPDSC-2722): update Select component defaults * chore(PPDSC-2722): update snapshots * chore(PPDSC-2722): remove codemod code * chore(PPDSC-2722): addProp util to support filtering by custom prop * chore(PPDSC-2722): fix typo * chore(PPDSC-2725): banner (#607) * chore(PPDSC-2725): banner default styling changes * chore(PPDSC-2725): vertical spacing * chore(PPDSC-2725): story update * chore(PPDSC-2725): snapshots * chore(PPDSC-2725): storybook styling * chore(PPDSC-2725): revert space inset changes * Chore/ppdsc 2778 tag default styles (#622) * chore(PPDSC-2778): updatedt tests * chore(PPDSC-2778): updatedt tests * chore(PPDSC-2778): updatedt tests-stack child * feat(PPDSC-2781): update menu defaults (#616) * feat(PPDSC-2781): update menu defaults * fix(PPDSC-2781): update menu * fix(PPDSC-2781): update docs * fix(PPDSC-2781): remove extra border-box * chore(PPDSC-2780): chore/ppdse-2780-titlebar-defaults fixed defaults (#605) * chore(PPDSC-2780): chore/ppdse-2780-titlebar-defaults fixed defaults * chore(PPDSC-2780): chore/ppdse-2780-titlebar-defaults fixed defaults * chore(PPDSC-2780): chore/ppdse-2780-titlebar-defaults-add logicap props * chore(PPDSC-2780): chore/ppdse-2780-added logical props * chore(PPDSC-2780): updatedt tests * chore(PPDSC-2780): updatedt tests-theme * chore(PPDSC-2780): updatedt tests-accsessbility * chore(PPDSC-2780): updatedt tests-site * chore(PPDSC-2780): updatedt tests for logical props * chore(PPDSC-2780): updatedt tests for LP * chore(PPDSC-2780): chore/ppdse-2780-updated types * chore(PPDSC-2780): chore/ppdse-2780-updated stories * chore(PPDSC-2780): chore/ppdse-2780-tidied * chore(PPDSC-2780): chore/ppdse-2780-tidied * chore(PPDSC-2780): chore/ppdse-2780-updated snap * chore(PPDSC-2780): chore/ppdse-2780-updated snapsshots * chore(PPDSC-2780): chore/ppdse-2780-fixed * chore(PPDSC-2780): chore/ppdse-2780-updated tests fixed merge * chore(PPDSC-2780): chore/ppdse-2780-section intro update * chore(PPDSC-2780): chore/ppdse-2780-updated select * chore(PPDSC-2780): chore/ppdse-2780-updated documentatyion * feat(PPDSC-1940): remove Link component (#624) * feat(PPDSC-1940): remove Link component * feat(PPDSC-1940): fix tests * feat(PPDSC-1940): updated gitignore --------- Co-authored-by: Vanals <marco91vanali@gmail.com> * feat(PPDSC2091): caption refactoring (#627) * feat(PPDSC-2091): remove caption-inset and refactor caption * feat(PPDSC-2091): add codemod for caption * feat(PPDSC-2091): add codemod * feat(PPDSC-2091): finish codemod * feat(PPDSC-2091): add correct spacing * feat(PPDSC-2091): update docs * feat(PPDSC-2091): formating * feat(PPDSC-2091): made generic space-inset replace fn * feat(PPDSC-2091): fix lint * feat(PPDSC-2091): rename file * feat(PPDSC-2091): fix tests * feat(PPDSC-2091): address comments * feat(PPDSC-2091): update default credit style-preset * feat(PPDSC-2091): update docs * feat(PPDSC-2798): add css variables * feat(PPDSC-2798): add files * feat(PPDSC-2798): add fonts * feat(PPDSC-2798): update site snapshots * feat(PPDSC-2422): update newskit light and dark theme tokens (#632) * feat(PPDSC-2422): update newskit light and dark theme tokens * feat(PPDSC-2422): update snapshots * feat(PPDSC-2428): Popover Tooltip AudioPlayer override name (#641) * feat(PPDSC-2428): popover tooltip audio player override name * feat(PPDSC-2428): update snapshots * feat(PPDSC-2798): update docs * chore(PPDSC-1866): remove crop config (#625) * chore(PPDSC-1866): remove crop config * chore(PPDSC-1866): switch to font metrics * chore(PPDSC-1866): fix coverage * chore(PPDSC-1866): snapshots * chore(PPDSC-1866): update snapshots * chore(PPDSC-1866): update snapshots * chore(PPDSC-1866): remove old comments * feat(PPDSC-2798): fix coverage * feat(PPDSC-2798): fixing tests * feat(PPDSC-2798): fix tests * feat(PPDSC-2798): rename-var * feat(PPDSC-2798): update tests --------- Co-authored-by: JohnTParsons <JohnTParsons> Co-authored-by: mstuartf <mstuartflood@gmail.com> Co-authored-by: Marco Vanali <Marco91Vanali@gmail.com> Co-authored-by: Xin Wang <wangxin00163@yahoo.co.uk> Co-authored-by: JohnTParsons <JohnTParsons@users.noreply.github.com> Co-authored-by: Evgeni Nikolov <evgeni.nikolov@news.co.uk> Co-authored-by: baburay23 <54642337+baburay23@users.noreply.github.com>
* chore(PPDSC-2412): major version 7.0.1 * chore(PPDSC-2412): audio player styling changes (#592) * chore(PPDSC-2412): audio player styling changes * chore(PPDSC-2412): linting and comments * chore(PPDSC-2412): typo * chore(PPDSC-2412): typo * chore(PPDSC-2412): simplify style presets * chore(PPDSC-2412): revert typo * chore(PPDSC-2412): update snapshots * chore(PPDSC-2412): add codemod to apply all style changes * chore(PPDSC-2412): update readme * feat(PPDSC-2782): changing dividerInverse color (#613) * feat(PPDSC-2782): changing sp * feat(PPDSC-2782): add new line * feat(PPDSC-2782): updated snap * chore(PPDSC-2775): update accordion default styles (#602) * fix(PPDSC-2775): update icon styles * fix(PPDSC-2775): design review * fix(PPDSC-2775): design reviews * chore(PPDSC-2412): audio player styling changes (#592) * chore(PPDSC-2412): audio player styling changes * chore(PPDSC-2412): linting and comments * chore(PPDSC-2412): typo * chore(PPDSC-2412): typo * chore(PPDSC-2412): simplify style presets * chore(PPDSC-2412): revert typo * chore(PPDSC-2412): update snapshots * chore(PPDSC-2412): add codemod to apply all style changes * chore(PPDSC-2412): update readme * chore(PPDSC-2775): codemod for accordion * fix(PPDSC-2775): revert readme * fix(PPDSC-2775): lint and snapshots * fix(PPDSC-2775): update codemods * fix(PPDSC-2775): lint * fix(PPDSC-2775): lint * fix(PPDSC-2775): remove fontColorChange from button --------- Co-authored-by: mstuartf <mstuartflood@gmail.com> * fix(PPDSC-2779): Improve handling of OrderedList paragraph scenario (#612) * fix(PPDSC-2779): improve handling of OrderedList paragraph scenario --------- Co-authored-by: JohnTParsons <JohnTParsons> * chore(PPDSC-2723): update Slider component defaults (#606) * chore(PPDSC-2723): update Slider component defaults * chore(PPDSC-2723): remove codemod * chore(PPDSC-2723): update snapshots * chore(PPDSC-2723): remove line from readme * chore(PPDSC-2776): update Link component defaults (#614) * chore(PPDSC-2776): link updates * chore(PPDSC-2776): lint fix * feat(PPDSC-2726): update snap (#615) * chore(PPDSC-2774): update Popover component defaults (#617) * chore(PPDSC-2774): update Popover component defaults * chore(PPDSC-2774): update snapshots * chore(PPDSC-2722): update Select component defaults (#608) * chore(PPDSC-2722): update Select component defaults * chore(PPDSC-2722): update snapshots * chore(PPDSC-2722): remove codemod code * chore(PPDSC-2722): addProp util to support filtering by custom prop * chore(PPDSC-2722): fix typo * chore(PPDSC-2725): banner (#607) * chore(PPDSC-2725): banner default styling changes * chore(PPDSC-2725): vertical spacing * chore(PPDSC-2725): story update * chore(PPDSC-2725): snapshots * chore(PPDSC-2725): storybook styling * chore(PPDSC-2725): revert space inset changes * Chore/ppdsc 2778 tag default styles (#622) * chore(PPDSC-2778): updatedt tests * chore(PPDSC-2778): updatedt tests * chore(PPDSC-2778): updatedt tests-stack child * feat(PPDSC-2781): update menu defaults (#616) * feat(PPDSC-2781): update menu defaults * fix(PPDSC-2781): update menu * fix(PPDSC-2781): update docs * fix(PPDSC-2781): remove extra border-box * chore(PPDSC-2780): chore/ppdse-2780-titlebar-defaults fixed defaults (#605) * chore(PPDSC-2780): chore/ppdse-2780-titlebar-defaults fixed defaults * chore(PPDSC-2780): chore/ppdse-2780-titlebar-defaults fixed defaults * chore(PPDSC-2780): chore/ppdse-2780-titlebar-defaults-add logicap props * chore(PPDSC-2780): chore/ppdse-2780-added logical props * chore(PPDSC-2780): updatedt tests * chore(PPDSC-2780): updatedt tests-theme * chore(PPDSC-2780): updatedt tests-accsessbility * chore(PPDSC-2780): updatedt tests-site * chore(PPDSC-2780): updatedt tests for logical props * chore(PPDSC-2780): updatedt tests for LP * chore(PPDSC-2780): chore/ppdse-2780-updated types * chore(PPDSC-2780): chore/ppdse-2780-updated stories * chore(PPDSC-2780): chore/ppdse-2780-tidied * chore(PPDSC-2780): chore/ppdse-2780-tidied * chore(PPDSC-2780): chore/ppdse-2780-updated snap * chore(PPDSC-2780): chore/ppdse-2780-updated snapsshots * chore(PPDSC-2780): chore/ppdse-2780-fixed * chore(PPDSC-2780): chore/ppdse-2780-updated tests fixed merge * chore(PPDSC-2780): chore/ppdse-2780-section intro update * chore(PPDSC-2780): chore/ppdse-2780-updated select * chore(PPDSC-2780): chore/ppdse-2780-updated documentatyion * feat(PPDSC-1940): remove Link component (#624) * feat(PPDSC-1940): remove Link component * feat(PPDSC-1940): fix tests * feat(PPDSC-1940): updated gitignore --------- Co-authored-by: Vanals <marco91vanali@gmail.com> * feat(PPDSC2091): caption refactoring (#627) * feat(PPDSC-2091): remove caption-inset and refactor caption * feat(PPDSC-2091): add codemod for caption * feat(PPDSC-2091): add codemod * feat(PPDSC-2091): finish codemod * feat(PPDSC-2091): add correct spacing * feat(PPDSC-2091): update docs * feat(PPDSC-2091): formating * feat(PPDSC-2091): made generic space-inset replace fn * feat(PPDSC-2091): fix lint * feat(PPDSC-2091): rename file * feat(PPDSC-2091): fix tests * feat(PPDSC-2091): address comments * feat(PPDSC-2091): update default credit style-preset * feat(PPDSC-2091): update docs * feat(PPDSC-2422): update newskit light and dark theme tokens (#632) * feat(PPDSC-2422): update newskit light and dark theme tokens * feat(PPDSC-2422): update snapshots * feat(PPDSC-2428): Popover Tooltip AudioPlayer override name (#641) * feat(PPDSC-2428): popover tooltip audio player override name * feat(PPDSC-2428): update snapshots * chore(PPDSC-1866): remove crop config (#625) * chore(PPDSC-1866): remove crop config * chore(PPDSC-1866): switch to font metrics * chore(PPDSC-1866): fix coverage * chore(PPDSC-1866): snapshots * chore(PPDSC-1866): update snapshots * chore(PPDSC-1866): update snapshots * chore(PPDSC-1866): remove old comments * feat(PPDSC-2817): replace space inset (#642) * feat(PPDCS-2817): banner, block, card, flag, button, iconButton * feat(PPDCS-2817): menu fieldset and gridlayout * feat(PPDCS-2817): select * feat(PPDCS-2817): strucutured list * feat(PPDCS-2817): text-field * feat(PPDCS-2817): tabs * feat(PPDCS-2817): toast, video-player * feat(PPDCS-2817): tag, toast and dialog * fix(PPDCS-2817): update docs token * feat(PPDCS-2817): codemod & tests * fix(PPDCS-2817): run codemod on site * fix(PPDCS-2817): update docs types and codemod * fix(PPDCS-2817): update snapshots * feat(PPDCS-2817): split into start and end in defaults * fix(PPDCS-2817): lint * fix(PPDCS-2817): remove test.only * fix(PPDCS-2817): sidebar * feat(PPDCS-2817): Revert "feat(PPDCS-2817): split into start and end in defaults" This reverts commit d2b4541. * fix(PPDCS-2817): change logical props order * fix(PPDCS-2817): update docs * fix(PPDCS-2817): test * fix(PPDCS-2817): update more docs * fix(PPDCS-2817): address reviews * fix(PPDCS-2817): update snapshots * fix(PPDCS-2817): codemod when stylePreset is added to Block * fix(PPDCS-2817): add logical props to accordion * fix(PPDCS-2817): update name * fix(PPDCS-2817): remove logical props from accordion group * chore(PPDSC-0000): typo * chore(PPDSC-0000): snapshot fix * fix(PPDSC-0000): update tests --------- Co-authored-by: JohnTParsons <JohnTParsons> Co-authored-by: Marco Vanali <Marco91Vanali@gmail.com> Co-authored-by: Xin Wang <wangxin00163@yahoo.co.uk> Co-authored-by: JohnTParsons <JohnTParsons@users.noreply.github.com> Co-authored-by: Evgeni Nikolov <evgeni.nikolov@news.co.uk> Co-authored-by: baburay23 <54642337+baburay23@users.noreply.github.com> Co-authored-by: Stoyan Delev <stoyan.delev@news.co.uk> Co-authored-by: Stoyan Delev <mutebg@users.noreply.github.com> Co-authored-by: Michael Flood <michaelflood@Michaels-Mac-mini.local>
* chore(PPDSC-2412): major version 7.0.1 * chore(PPDSC-2412): audio player styling changes (#592) * chore(PPDSC-2412): audio player styling changes * chore(PPDSC-2412): linting and comments * chore(PPDSC-2412): typo * chore(PPDSC-2412): typo * chore(PPDSC-2412): simplify style presets * chore(PPDSC-2412): revert typo * chore(PPDSC-2412): update snapshots * chore(PPDSC-2412): add codemod to apply all style changes * chore(PPDSC-2412): update readme * feat(PPDSC-2782): changing dividerInverse color (#613) * feat(PPDSC-2782): changing sp * feat(PPDSC-2782): add new line * feat(PPDSC-2782): updated snap * chore(PPDSC-2775): update accordion default styles (#602) * fix(PPDSC-2775): update icon styles * fix(PPDSC-2775): design review * fix(PPDSC-2775): design reviews * chore(PPDSC-2412): audio player styling changes (#592) * chore(PPDSC-2412): audio player styling changes * chore(PPDSC-2412): linting and comments * chore(PPDSC-2412): typo * chore(PPDSC-2412): typo * chore(PPDSC-2412): simplify style presets * chore(PPDSC-2412): revert typo * chore(PPDSC-2412): update snapshots * chore(PPDSC-2412): add codemod to apply all style changes * chore(PPDSC-2412): update readme * chore(PPDSC-2775): codemod for accordion * fix(PPDSC-2775): revert readme * fix(PPDSC-2775): lint and snapshots * fix(PPDSC-2775): update codemods * fix(PPDSC-2775): lint * fix(PPDSC-2775): lint * fix(PPDSC-2775): remove fontColorChange from button --------- Co-authored-by: mstuartf <mstuartflood@gmail.com> * fix(PPDSC-2779): Improve handling of OrderedList paragraph scenario (#612) * fix(PPDSC-2779): improve handling of OrderedList paragraph scenario --------- Co-authored-by: JohnTParsons <JohnTParsons> * chore(PPDSC-2723): update Slider component defaults (#606) * chore(PPDSC-2723): update Slider component defaults * chore(PPDSC-2723): remove codemod * chore(PPDSC-2723): update snapshots * chore(PPDSC-2723): remove line from readme * chore(PPDSC-2776): update Link component defaults (#614) * chore(PPDSC-2776): link updates * chore(PPDSC-2776): lint fix * feat(PPDSC-2726): update snap (#615) * chore(PPDSC-2774): update Popover component defaults (#617) * chore(PPDSC-2774): update Popover component defaults * chore(PPDSC-2774): update snapshots * chore(PPDSC-2722): update Select component defaults (#608) * chore(PPDSC-2722): update Select component defaults * chore(PPDSC-2722): update snapshots * chore(PPDSC-2722): remove codemod code * chore(PPDSC-2722): addProp util to support filtering by custom prop * chore(PPDSC-2722): fix typo * chore(PPDSC-2725): banner (#607) * chore(PPDSC-2725): banner default styling changes * chore(PPDSC-2725): vertical spacing * chore(PPDSC-2725): story update * chore(PPDSC-2725): snapshots * chore(PPDSC-2725): storybook styling * chore(PPDSC-2725): revert space inset changes * Chore/ppdsc 2778 tag default styles (#622) * chore(PPDSC-2778): updatedt tests * chore(PPDSC-2778): updatedt tests * chore(PPDSC-2778): updatedt tests-stack child * feat(PPDSC-2781): update menu defaults (#616) * feat(PPDSC-2781): update menu defaults * fix(PPDSC-2781): update menu * fix(PPDSC-2781): update docs * fix(PPDSC-2781): remove extra border-box * chore(PPDSC-2780): chore/ppdse-2780-titlebar-defaults fixed defaults (#605) * chore(PPDSC-2780): chore/ppdse-2780-titlebar-defaults fixed defaults * chore(PPDSC-2780): chore/ppdse-2780-titlebar-defaults fixed defaults * chore(PPDSC-2780): chore/ppdse-2780-titlebar-defaults-add logicap props * chore(PPDSC-2780): chore/ppdse-2780-added logical props * chore(PPDSC-2780): updatedt tests * chore(PPDSC-2780): updatedt tests-theme * chore(PPDSC-2780): updatedt tests-accsessbility * chore(PPDSC-2780): updatedt tests-site * chore(PPDSC-2780): updatedt tests for logical props * chore(PPDSC-2780): updatedt tests for LP * chore(PPDSC-2780): chore/ppdse-2780-updated types * chore(PPDSC-2780): chore/ppdse-2780-updated stories * chore(PPDSC-2780): chore/ppdse-2780-tidied * chore(PPDSC-2780): chore/ppdse-2780-tidied * chore(PPDSC-2780): chore/ppdse-2780-updated snap * chore(PPDSC-2780): chore/ppdse-2780-updated snapsshots * chore(PPDSC-2780): chore/ppdse-2780-fixed * chore(PPDSC-2780): chore/ppdse-2780-updated tests fixed merge * chore(PPDSC-2780): chore/ppdse-2780-section intro update * chore(PPDSC-2780): chore/ppdse-2780-updated select * chore(PPDSC-2780): chore/ppdse-2780-updated documentatyion * feat(PPDSC-1940): remove Link component (#624) * feat(PPDSC-1940): remove Link component * feat(PPDSC-1940): fix tests * feat(PPDSC-1940): updated gitignore --------- Co-authored-by: Vanals <marco91vanali@gmail.com> * feat(PPDSC2091): caption refactoring (#627) * feat(PPDSC-2091): remove caption-inset and refactor caption * feat(PPDSC-2091): add codemod for caption * feat(PPDSC-2091): add codemod * feat(PPDSC-2091): finish codemod * feat(PPDSC-2091): add correct spacing * feat(PPDSC-2091): update docs * feat(PPDSC-2091): formating * feat(PPDSC-2091): made generic space-inset replace fn * feat(PPDSC-2091): fix lint * feat(PPDSC-2091): rename file * feat(PPDSC-2091): fix tests * feat(PPDSC-2091): address comments * feat(PPDSC-2091): update default credit style-preset * feat(PPDSC-2091): update docs * feat(PPDSC-2798): add css variables * feat(PPDSC-2798): add files * feat(PPDSC-2798): add fonts * feat(PPDSC-2798): update site snapshots * feat(PPDSC-2422): update newskit light and dark theme tokens (#632) * feat(PPDSC-2422): update newskit light and dark theme tokens * feat(PPDSC-2422): update snapshots * feat(PPDSC-2428): Popover Tooltip AudioPlayer override name (#641) * feat(PPDSC-2428): popover tooltip audio player override name * feat(PPDSC-2428): update snapshots * feat(PPDSC-2798): update docs * chore(PPDSC-1866): remove crop config (#625) * chore(PPDSC-1866): remove crop config * chore(PPDSC-1866): switch to font metrics * chore(PPDSC-1866): fix coverage * chore(PPDSC-1866): snapshots * chore(PPDSC-1866): update snapshots * chore(PPDSC-1866): update snapshots * chore(PPDSC-1866): remove old comments * feat(PPDSC-2798): fix coverage * feat(PPDSC-2798): fixing tests * feat(PPDSC-2798): fix tests * feat(PPDSC-2798): rename-var * feat(PPDSC-2798): update tests --------- Co-authored-by: JohnTParsons <JohnTParsons> Co-authored-by: mstuartf <mstuartflood@gmail.com> Co-authored-by: Marco Vanali <Marco91Vanali@gmail.com> Co-authored-by: Xin Wang <wangxin00163@yahoo.co.uk> Co-authored-by: JohnTParsons <JohnTParsons@users.noreply.github.com> Co-authored-by: Evgeni Nikolov <evgeni.nikolov@news.co.uk> Co-authored-by: baburay23 <54642337+baburay23@users.noreply.github.com>
PPDSC-2091
What
What did you do:
I have done:
I have tested manually:
Before:
After:
Who should review this PR:
How to test: