Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(PPDSC-2798): expose css variables #653

Merged
merged 36 commits into from Mar 1, 2023

Conversation

mutebg
Copy link
Contributor

@mutebg mutebg commented Feb 20, 2023

PPDSC-2798

What

  1. Background - why this is needed
  2. What did you do - added CSS variables to theme provider
  3. What does the reviewers should expect

I have done:

  • Written unit tests against changes
  • Written functional tests against the component and/or NewsKit site
  • Updated relevant documentation

I have tested manually:

  • The feature's functionality is working as expected on Chrome, Firefox, Safari and Edge
  • The screen reader reads and flows through the elements as expected.
  • There are no new errors in the browser console coming from this PR.
  • When visual test is not added, it renders correctly on different browsers and mobile viewports (Safari, Firefox, small mobile viewport, tablet)
  • The Playground feature is working as expected

Before:

After:

Who should review this PR:

How to test:

JohnTParsons and others added 19 commits January 31, 2023 12:34
* chore(PPDSC-2412): audio player styling changes

* chore(PPDSC-2412): linting and comments

* chore(PPDSC-2412): typo

* chore(PPDSC-2412): typo

* chore(PPDSC-2412): simplify style presets

* chore(PPDSC-2412): revert typo

* chore(PPDSC-2412): update snapshots

* chore(PPDSC-2412): add codemod to apply all style changes

* chore(PPDSC-2412): update readme
* feat(PPDSC-2782): changing sp

* feat(PPDSC-2782): add new line

* feat(PPDSC-2782): updated snap
* fix(PPDSC-2775): update icon styles

* fix(PPDSC-2775): design review

* fix(PPDSC-2775): design reviews

* chore(PPDSC-2412): audio player styling changes (#592)

* chore(PPDSC-2412): audio player styling changes

* chore(PPDSC-2412): linting and comments

* chore(PPDSC-2412): typo

* chore(PPDSC-2412): typo

* chore(PPDSC-2412): simplify style presets

* chore(PPDSC-2412): revert typo

* chore(PPDSC-2412): update snapshots

* chore(PPDSC-2412): add codemod to apply all style changes

* chore(PPDSC-2412): update readme

* chore(PPDSC-2775): codemod for accordion

* fix(PPDSC-2775): revert readme

* fix(PPDSC-2775): lint and snapshots

* fix(PPDSC-2775): update codemods

* fix(PPDSC-2775): lint

* fix(PPDSC-2775): lint

* fix(PPDSC-2775): remove fontColorChange from button

---------

Co-authored-by: mstuartf <mstuartflood@gmail.com>
…612)

* fix(PPDSC-2779): improve handling of OrderedList paragraph scenario

---------

Co-authored-by: JohnTParsons <JohnTParsons>
* chore(PPDSC-2723): update Slider component defaults

* chore(PPDSC-2723): remove codemod

* chore(PPDSC-2723): update snapshots

* chore(PPDSC-2723): remove line from readme
* chore(PPDSC-2774): update Popover component defaults

* chore(PPDSC-2774): update snapshots
* chore(PPDSC-2722): update Select component defaults

* chore(PPDSC-2722): update snapshots

* chore(PPDSC-2722): remove codemod code

* chore(PPDSC-2722): addProp util to support filtering by custom prop

* chore(PPDSC-2722): fix typo
* chore(PPDSC-2725): banner default styling changes

* chore(PPDSC-2725): vertical spacing

* chore(PPDSC-2725): story update

* chore(PPDSC-2725): snapshots

* chore(PPDSC-2725): storybook styling

* chore(PPDSC-2725): revert space inset changes
* chore(PPDSC-2778): updatedt tests

* chore(PPDSC-2778): updatedt tests

* chore(PPDSC-2778): updatedt tests-stack child
* feat(PPDSC-2781): update menu defaults

* fix(PPDSC-2781): update menu

* fix(PPDSC-2781): update docs

* fix(PPDSC-2781): remove extra border-box
…605)

* chore(PPDSC-2780): chore/ppdse-2780-titlebar-defaults fixed defaults

* chore(PPDSC-2780): chore/ppdse-2780-titlebar-defaults fixed defaults

* chore(PPDSC-2780): chore/ppdse-2780-titlebar-defaults-add logicap props

* chore(PPDSC-2780): chore/ppdse-2780-added logical props

* chore(PPDSC-2780): updatedt tests

* chore(PPDSC-2780): updatedt tests-theme

* chore(PPDSC-2780): updatedt tests-accsessbility

* chore(PPDSC-2780): updatedt tests-site

* chore(PPDSC-2780): updatedt tests for logical props

* chore(PPDSC-2780): updatedt tests for LP

* chore(PPDSC-2780): chore/ppdse-2780-updated types

* chore(PPDSC-2780): chore/ppdse-2780-updated stories

* chore(PPDSC-2780): chore/ppdse-2780-tidied

* chore(PPDSC-2780): chore/ppdse-2780-tidied

* chore(PPDSC-2780): chore/ppdse-2780-updated snap

* chore(PPDSC-2780): chore/ppdse-2780-updated snapsshots

* chore(PPDSC-2780): chore/ppdse-2780-fixed

* chore(PPDSC-2780): chore/ppdse-2780-updated tests fixed merge

* chore(PPDSC-2780): chore/ppdse-2780-section intro update

* chore(PPDSC-2780): chore/ppdse-2780-updated select

* chore(PPDSC-2780): chore/ppdse-2780-updated documentatyion
* feat(PPDSC-1940): remove Link component

* feat(PPDSC-1940): fix tests

* feat(PPDSC-1940): updated gitignore

---------

Co-authored-by: Vanals <marco91vanali@gmail.com>
* feat(PPDSC-2091): remove caption-inset  and refactor caption

* feat(PPDSC-2091): add codemod for caption

* feat(PPDSC-2091): add codemod

* feat(PPDSC-2091): finish codemod

* feat(PPDSC-2091): add correct spacing

* feat(PPDSC-2091): update docs

* feat(PPDSC-2091): formating

* feat(PPDSC-2091): made generic space-inset replace fn

* feat(PPDSC-2091): fix lint

* feat(PPDSC-2091): rename file

* feat(PPDSC-2091): fix tests

* feat(PPDSC-2091): address comments

* feat(PPDSC-2091): update default credit style-preset

* feat(PPDSC-2091): update docs
@mutebg mutebg changed the base branch from main to v7-breaking-changes February 20, 2023 12:51
@github-actions github-actions bot added the feature This change contains a new feature label Feb 20, 2023
@pp-serviceaccount
Copy link
Collaborator

Stoyan Delev and others added 7 commits February 20, 2023 15:48
* feat(PPDSC-2422): update newskit light and dark theme tokens

* feat(PPDSC-2422): update snapshots
* feat(PPDSC-2428): popover tooltip audio player override name

* feat(PPDSC-2428): update snapshots
* chore(PPDSC-1866): remove crop config

* chore(PPDSC-1866): switch to font metrics

* chore(PPDSC-1866): fix coverage

* chore(PPDSC-1866): snapshots

* chore(PPDSC-1866): update snapshots

* chore(PPDSC-1866): update snapshots

* chore(PPDSC-1866): remove old comments
@mutebg mutebg marked this pull request as ready for review February 22, 2023 10:20
@mstuartf
Copy link
Contributor

I think @LukeFinch's point about namespacing is a good one. But I think it's fine for now. If it turns out to be something we need, we could add support for an optional namespace prefix prop to be passed in along with exposeCssVariables.

mstuartf
mstuartf previously approved these changes Feb 24, 2023
@mutebg
Copy link
Contributor Author

mutebg commented Feb 27, 2023

I think @LukeFinch's point about namespacing is a good one. But I think it's fine for now. If it turns out to be something we need, we could add support for an optional namespace prefix prop to be passed in along with exposeCssVariables.

Thanks, I totally agree, let's see if anyone needs that we can easily add it as an additional option to the theme provider.

@mutebg mutebg changed the base branch from v7-breaking-changes to main March 1, 2023 06:44
@mutebg mutebg dismissed stale reviews from mstuartf, Xin00163, and JohnTParsons March 1, 2023 06:44

The base branch was changed.

Xin00163
Xin00163 previously approved these changes Mar 1, 2023
LukeFinch
LukeFinch previously approved these changes Mar 1, 2023
Copy link
Contributor

@LukeFinch LukeFinch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work 👏

JohnTParsons
JohnTParsons previously approved these changes Mar 1, 2023
@mutebg mutebg merged commit 30dfda1 into main Mar 1, 2023
@mutebg mutebg deleted the feat/PPDSC-2798-expose-css-variables branch March 1, 2023 14:26
JohnTParsons added a commit that referenced this pull request Mar 7, 2023
* chore(PPDSC-2412): major version 7.0.1

* chore(PPDSC-2412): audio player styling changes (#592)

* chore(PPDSC-2412): audio player styling changes

* chore(PPDSC-2412): linting and comments

* chore(PPDSC-2412): typo

* chore(PPDSC-2412): typo

* chore(PPDSC-2412): simplify style presets

* chore(PPDSC-2412): revert typo

* chore(PPDSC-2412): update snapshots

* chore(PPDSC-2412): add codemod to apply all style changes

* chore(PPDSC-2412): update readme

* feat(PPDSC-2782): changing dividerInverse color (#613)

* feat(PPDSC-2782): changing sp

* feat(PPDSC-2782): add new line

* feat(PPDSC-2782): updated snap

* chore(PPDSC-2775): update accordion default styles (#602)

* fix(PPDSC-2775): update icon styles

* fix(PPDSC-2775): design review

* fix(PPDSC-2775): design reviews

* chore(PPDSC-2412): audio player styling changes (#592)

* chore(PPDSC-2412): audio player styling changes

* chore(PPDSC-2412): linting and comments

* chore(PPDSC-2412): typo

* chore(PPDSC-2412): typo

* chore(PPDSC-2412): simplify style presets

* chore(PPDSC-2412): revert typo

* chore(PPDSC-2412): update snapshots

* chore(PPDSC-2412): add codemod to apply all style changes

* chore(PPDSC-2412): update readme

* chore(PPDSC-2775): codemod for accordion

* fix(PPDSC-2775): revert readme

* fix(PPDSC-2775): lint and snapshots

* fix(PPDSC-2775): update codemods

* fix(PPDSC-2775): lint

* fix(PPDSC-2775): lint

* fix(PPDSC-2775): remove fontColorChange from button

---------

Co-authored-by: mstuartf <mstuartflood@gmail.com>

* fix(PPDSC-2779): Improve handling of OrderedList paragraph scenario (#612)

* fix(PPDSC-2779): improve handling of OrderedList paragraph scenario

---------

Co-authored-by: JohnTParsons <JohnTParsons>

* chore(PPDSC-2723): update Slider component defaults (#606)

* chore(PPDSC-2723): update Slider component defaults

* chore(PPDSC-2723): remove codemod

* chore(PPDSC-2723): update snapshots

* chore(PPDSC-2723): remove line from readme

* chore(PPDSC-2776): update Link component defaults (#614)

* chore(PPDSC-2776): link updates

* chore(PPDSC-2776): lint fix

* feat(PPDSC-2726): update snap (#615)

* chore(PPDSC-2774): update Popover component defaults (#617)

* chore(PPDSC-2774): update Popover component defaults

* chore(PPDSC-2774): update snapshots

* chore(PPDSC-2722): update Select component defaults (#608)

* chore(PPDSC-2722): update Select component defaults

* chore(PPDSC-2722): update snapshots

* chore(PPDSC-2722): remove codemod code

* chore(PPDSC-2722): addProp util to support filtering by custom prop

* chore(PPDSC-2722): fix typo

* chore(PPDSC-2725): banner (#607)

* chore(PPDSC-2725): banner default styling changes

* chore(PPDSC-2725): vertical spacing

* chore(PPDSC-2725): story update

* chore(PPDSC-2725): snapshots

* chore(PPDSC-2725): storybook styling

* chore(PPDSC-2725): revert space inset changes

* Chore/ppdsc 2778 tag default styles (#622)

* chore(PPDSC-2778): updatedt tests

* chore(PPDSC-2778): updatedt tests

* chore(PPDSC-2778): updatedt tests-stack child

* feat(PPDSC-2781): update menu defaults (#616)

* feat(PPDSC-2781): update menu defaults

* fix(PPDSC-2781): update menu

* fix(PPDSC-2781): update docs

* fix(PPDSC-2781): remove extra border-box

* chore(PPDSC-2780): chore/ppdse-2780-titlebar-defaults fixed defaults (#605)

* chore(PPDSC-2780): chore/ppdse-2780-titlebar-defaults fixed defaults

* chore(PPDSC-2780): chore/ppdse-2780-titlebar-defaults fixed defaults

* chore(PPDSC-2780): chore/ppdse-2780-titlebar-defaults-add logicap props

* chore(PPDSC-2780): chore/ppdse-2780-added logical props

* chore(PPDSC-2780): updatedt tests

* chore(PPDSC-2780): updatedt tests-theme

* chore(PPDSC-2780): updatedt tests-accsessbility

* chore(PPDSC-2780): updatedt tests-site

* chore(PPDSC-2780): updatedt tests for logical props

* chore(PPDSC-2780): updatedt tests for LP

* chore(PPDSC-2780): chore/ppdse-2780-updated types

* chore(PPDSC-2780): chore/ppdse-2780-updated stories

* chore(PPDSC-2780): chore/ppdse-2780-tidied

* chore(PPDSC-2780): chore/ppdse-2780-tidied

* chore(PPDSC-2780): chore/ppdse-2780-updated snap

* chore(PPDSC-2780): chore/ppdse-2780-updated snapsshots

* chore(PPDSC-2780): chore/ppdse-2780-fixed

* chore(PPDSC-2780): chore/ppdse-2780-updated tests fixed merge

* chore(PPDSC-2780): chore/ppdse-2780-section intro update

* chore(PPDSC-2780): chore/ppdse-2780-updated select

* chore(PPDSC-2780): chore/ppdse-2780-updated documentatyion

* feat(PPDSC-1940): remove Link component (#624)

* feat(PPDSC-1940): remove Link component

* feat(PPDSC-1940): fix tests

* feat(PPDSC-1940): updated gitignore

---------

Co-authored-by: Vanals <marco91vanali@gmail.com>

* feat(PPDSC2091): caption refactoring (#627)

* feat(PPDSC-2091): remove caption-inset  and refactor caption

* feat(PPDSC-2091): add codemod for caption

* feat(PPDSC-2091): add codemod

* feat(PPDSC-2091): finish codemod

* feat(PPDSC-2091): add correct spacing

* feat(PPDSC-2091): update docs

* feat(PPDSC-2091): formating

* feat(PPDSC-2091): made generic space-inset replace fn

* feat(PPDSC-2091): fix lint

* feat(PPDSC-2091): rename file

* feat(PPDSC-2091): fix tests

* feat(PPDSC-2091): address comments

* feat(PPDSC-2091): update default credit style-preset

* feat(PPDSC-2091): update docs

* feat(PPDSC-2798): add css variables

* feat(PPDSC-2798): add files

* feat(PPDSC-2798): add fonts

* feat(PPDSC-2798): update site snapshots

* feat(PPDSC-2422): update newskit light and dark theme tokens (#632)

* feat(PPDSC-2422): update newskit light and dark theme tokens

* feat(PPDSC-2422): update snapshots

* feat(PPDSC-2428): Popover Tooltip AudioPlayer override name (#641)

* feat(PPDSC-2428): popover tooltip audio player override name

* feat(PPDSC-2428): update snapshots

* feat(PPDSC-2798): update docs

* chore(PPDSC-1866): remove crop config (#625)

* chore(PPDSC-1866): remove crop config

* chore(PPDSC-1866): switch to font metrics

* chore(PPDSC-1866): fix coverage

* chore(PPDSC-1866): snapshots

* chore(PPDSC-1866): update snapshots

* chore(PPDSC-1866): update snapshots

* chore(PPDSC-1866): remove old comments

* feat(PPDSC-2798): fix coverage

* feat(PPDSC-2798): fixing tests

* feat(PPDSC-2798): fix tests

* feat(PPDSC-2798): rename-var

* feat(PPDSC-2798): update tests

---------

Co-authored-by: JohnTParsons <JohnTParsons>
Co-authored-by: mstuartf <mstuartflood@gmail.com>
Co-authored-by: Marco Vanali <Marco91Vanali@gmail.com>
Co-authored-by: Xin Wang <wangxin00163@yahoo.co.uk>
Co-authored-by: JohnTParsons <JohnTParsons@users.noreply.github.com>
Co-authored-by: Evgeni Nikolov <evgeni.nikolov@news.co.uk>
Co-authored-by: baburay23 <54642337+baburay23@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature This change contains a new feature ready for review Please assist in getting this reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants