Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix default value for consumer type #151

Merged
merged 1 commit into from
Mar 9, 2023
Merged

Conversation

imran2140
Copy link
Collaborator

Default value for consumer type needs to be 1, as existing consumers are supposed to be push based.

Default value for consumer type needs to be `1`,
as existing consumers are supposed to be push based.
@oneshadab
Copy link
Member

oneshadab commented Mar 9, 2023

Would swapping the two lines 11 and 12 be an easier solution?

That way if we initialize ConsumerType with it's zero value anywhere in the codebase, it would be push by default.

@imyousuf
Copy link
Collaborator

imyousuf commented Mar 9, 2023

Would swapping the two lines 11 and 12 be an easier solution?

That way if we initialize ConsumerType with it's zero value anywhere in the codebase, it would be push by default.

I would not switch iota values, I would like to keep them as constant as possible

@imyousuf imyousuf merged commit ce8a760 into main Mar 9, 2023
@imyousuf
Copy link
Collaborator

Addresses part of #53

@imran2140 imran2140 deleted the fix-default-value-for-consumer branch March 21, 2023 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants