-
Notifications
You must be signed in to change notification settings - Fork 53
Loosen the version constraint of requests to avoid dependency conflicts #343
Comments
Dependency tree-----
|
@palewire,Could you help me review this issue? Thx :p |
Sames goes for urllib3, which is currently set to >=1.21.1,<1.24 (current version is 1.25.11) |
Nevermind, this is the same as above, as urllib3 is a dependency of requests. |
Sorry to have neglected this. Yes, I can think we can work this out. |
Here's what I see now. What needs to change in your view? install_requires=[
"CacheControl==0.12.*",
"cement==2.10.2",
"lockfile==0.12.2",
"pymongo==3.3",
"python-dateutil==2.7.*",
"requests==2.20.*",
"ujson==1.35",
], |
I'd defer to you all on most of this, but when I upped the requests requirement to be "requests>=2.20.*" that fixed my immediate issue. I have no reason to doubt the suggestion in the original issue message for requests >=2.19.0, though. |
I see 2.20 in the setup.py right now though. Am I nuts? |
equals, though, not greater than |
setting a new max is a philosophical question, but the conflict this caused for me was with awscli, so seems like other libraries have moved on |
Okay. I filed a pull request on your behalf. @jeremyjbowers and @eads will have to decide. |
@palewire @mikejcorey Thank you very much. |
Hi, elex locked the version constraint of requests as requests ==2.19., which leads a troubling scenario to its direct downstream project ** politico-civic-election-night ** which has dependency requests.
Could you please loosen the version constraint of requests?
Benefit of this is that users using both of elex and requests can upgrade their third party libraries in a timely manner to reduce technical debts.
Solution
The dependency trees of your project and affected downstream projects are shown as follows.
Taking the version constraints of upstream and downstream projects into comprehensive consideration, you can
@eads May I submit a PR to this issue?
Thanks for your attention.
Best,
Neolith
The text was updated successfully, but these errors were encountered: