Library set up #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 6, 2020 11:02
ajabdelaziz
requested review from
kristophM and
thequinto
and removed request for
kristophM and
thequinto
thequinto
approved these changes
Oct 7, 2020
There was a problem hiding this comment.
I was able to pull this branch, install, and log in JSON format:
{"levelname": "WARNING", "asctime": "2020-10-07 23:20:04,178", "module": "log", "process": 85556, "thread": 4395158976, "message": "Not Found: /api/v1/projects/3417/", "status_code": 404, "request": "<WSGIRequest: PATCH '/api/v1/projects/3417/'>", "severity": "WARNING"}
Just needs to be repackaged under pysdl instead of pydsl (assuming it stands for StackDriver Logging), but LGTM.
README.md
Outdated
| settings.py -> | ||
|
|
||
| ```python | ||
| from pydsl.logger_config import logging_dict |
There was a problem hiding this comment.
should be pysdl instead of pydsl, and likewise with line 17
| from logging.config import dictConfig | ||
| from pydsl.logger_config import logging_dict | ||
| dictConfig(logging_dict) | ||
| ``` |
There was a problem hiding this comment.
Add an example to actually write something to logs? I used the snippet below:
log = logging.getLogger("testfile")
log.info("hello world")
|
@thequinto Should be fixed now. Thanks for reviewing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set ups the library pysdl to be pulled into other projects and automatically configure and fix python-json-logger to be correctly consumed by stack driver logging.