Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support shortcut flags for cli #2951

Merged
merged 1 commit into from
Jun 10, 2022
Merged

Support shortcut flags for cli #2951

merged 1 commit into from
Jun 10, 2022

Conversation

lf32
Copy link

@lf32 lf32 commented May 11, 2022

Supports

-A about
-q quiet
-v verbose
-V Version

shortcut flags

Fixes #2949

@lf32 lf32 mentioned this pull request May 11, 2022
Closed
1 task
pombredanne
pombredanne requested changes May 13, 2022
View reviewed changes
Copy link
Member

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are all making sense! Thanks. Do you mind to also keep some test that uses the long form version?
And also add you name to the AUTHORs and update the changelog ?
Thanks!

@lf32
Copy link
Author

lf32 commented May 14, 2022 •
edited
Loading

Do you mind to also keep some test that uses the long form version?

There are many tests which use long form version, I've altered only some of them to test for short flags but now I have added few more changes to other functions. The tests will now use both short form and long form versions
Thanks!

@lf32 lf32 changed the title Supports shortcut flags for cli Support shortcut flags for cli May 16, 2022
@lf32 lf32 force-pushed the shortcut-flgs branch 2 times, most recently from d7c3e7d to 9912ab7 Compare May 17, 2022 12:37
@lf32 lf32 force-pushed the shortcut-flgs branch 4 times, most recently from 37a1ea7 to ef669a7 Compare May 29, 2022 06:53
@lf32
Support shortcut flags for cli
e6e0602 
Signed-off-by: Akhil Raj <lf32.dev@gmail.com>
@lf32
Copy link
Author

lf32 commented Jun 10, 2022

Is everything ok with this?

pombredanne
pombredanne approved these changes Jun 10, 2022
View reviewed changes
Copy link
Member

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! thanks

@pombredanne pombredanne merged commit 2c49c4c into aboutcode-org:develop Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pombredanne pombredanne pombredanne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support shortcut flags
2 participants
@lf32 @pombredanne