Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit tests #591

Merged
merged 50 commits into from
Oct 25, 2023
Merged

Unit tests #591

merged 50 commits into from
Oct 25, 2023

Conversation

OmkarPh
Copy link
Collaborator

@OmkarPh OmkarPh commented Jul 28, 2023 •
edited
Loading

Also fixes #601

@OmkarPh
Setup basic unit tests for utilities
03a7d8a 
Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com>
@OmkarPh
Merge remote-tracking branch 'origin/v4.0-react-typescript' into feat…
f5bf73a 
…ure/unittests
@OmkarPh
Completed tests for utils
bfc2a73 
Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com>
@OmkarPh
Completed tests for verifying header imports
6058858 
Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com>
@OmkarPh
Merge remote-tracking branch 'origin/v4.0-react-typescript' into feat…
3add0f1 
…ure/unittests
@OmkarPh
Merge remote-tracking branch 'origin/v4.0-react-typescript' into feat…
cf8ffcd 
…ure/unittests
@OmkarPh
Refactor parser, Added tests for Copyright & headers
3729ae9 
Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com>
@OmkarPh
Added tests for copyright, licenses, email_url_info
76e1a85 
Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com>
@OmkarPh
Fixed scan errors in table & ScanInfo, and added tests for scanErrors
2bc6bd2 
Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com>
@OmkarPh
Reorganized tests
f37a0c5 
Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com>
@OmkarPh
Merge remote-tracking branch 'origin/experiment/dependenciesViews' in…
07fb6b8 
…to feature/unittests
@OmkarPh
Added tests for packages & dependencies, Setup Tests CI
fcc0400 
Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com>
@OmkarPh
Test ci - fix attempt1
ef7319d 
Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com>
@OmkarPh
Merge remote-tracking branch 'origin/experiment/dependenciesViews' in…
41b53d2 
…to feature/unittests
@OmkarPh
Merge remote-tracking branch 'origin/v4.0-react-typescript' into feat…
d361052 
…ure/unittests
@OmkarPh
Completed tests and refactoring for File tree, history & misc test
99b1d4b 
Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com>
@OmkarPh
Tests for tableview columns and filters
d25c101 
Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com>
@OmkarPh
Added latest sample scans & updated readme
2ebe01b 
Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com>
@OmkarPh OmkarPh marked this pull request as ready for review August 26, 2023 18:34
@OmkarPh
Updated publish comments & code formatting
989e44d 
Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com>
@OmkarPh
Implemented close file button, menu item and before new scan import
9281b52 
Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com>
@OmkarPh
Fixed #590 scrolling irregularities in deeply nested filetree
0d8163c 
Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com>
@OmkarPh
Added dev script for docs & installation steps for centos
644af13 
Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com>
@OmkarPh
Setup precommit hooks for tests using husky
96d85b8 
Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com>
@OmkarPh OmkarPh linked an issue Sep 9, 2023 that may be closed by this pull request
Husky pre-commit hooks for tests #601
Open
@OmkarPh
Merged skeleton docs
f6a0d84 
Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com>
@OmkarPh
Fixed previous title preserved on closing file
f39c86a 
Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com>
@OmkarPh
Docs for Tableview
e54493f 
Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com>
OmkarPh and others added 23 commits September 15, 2023 23:58
@OmkarPh
Added directory-tree docs & column list for tableview
45c7367 
Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com>
@OmkarPh
Updated docs with latest information
d87295a 
Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com>
@OmkarPh
Removed year from project's copyright statements
89083c7 
Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com>
@OmkarPh
Fixed sphinx errors, changed requirements versions, formatting and bu…
9e96f9e 
…ild errors

Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com>
@OmkarPh
Fixed unnecessary scrolling on click, added working indicator for fil…
ab53936 
…etree render

Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com>
@OmkarPh
Fixed #542 file icon being shown for empty directories
a9c97e8 
Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com>
@OmkarPh
Merge pull request #599 from nexB/fix/scrolltofile
a3dd1b5 
Fix irregular scroll behavior for files in deeply nested FileTree
@OmkarPh
Merge pull request #600 from nexB/feature/closefile
8688efd 
Close file option & cleanup before imports
@OmkarPh
Merge branch 'feature/unittests' into update/docs
bc838c5
@OmkarPh
Updated documentation scripts
9eadc37 
Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com>
@OmkarPh
Setup automatic height & max height for matches & file regions table
9eb26f0 
Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com>
@OmkarPh
Fixed auto height for package & dependency entity
1626bab 
Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com>
@OmkarPh
Updated docs config, dark theme, UI reference updates
d86c93f 
Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com>
@OmkarPh
Updated config for readthedocs deploys
af16680 
Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com>
@OmkarPh
Completed UI references, refer-scans, sct-swb interlinks
6c92d66 
Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com>
@AyanSinhaMahapatra
Add minor fixes in workbench docs
be37218 
Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
@OmkarPh
Merge pull request #604 from nexB/fix/emptyDirectoryIcon
241487f 
Fixed Empty directory being shown with file icon
@OmkarPh
Handled summary table for packages without dependencies & adjusted ta…
e397372 
…ble dimensions

Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com>
@OmkarPh
Added Docs CI, fixed minor docs errors
7e00d58 
Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com>
@AyanSinhaMahapatra
Add minor doc updates
e7914f4 
Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
@AyanSinhaMahapatra
Merge pull request #606 from nexB/fix/autoTableDimensions
d21e55d 
Automatic height for table
@OmkarPh
Updated underlying technology, build tools versions, removed policies…
8a217c8 
… outdated docs

Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com>
@OmkarPh
Updated jest config
4afe992 
Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com>
AyanSinhaMahapatra
AyanSinhaMahapatra approved these changes Oct 25, 2023
View reviewed changes
Copy link
Member

@AyanSinhaMahapatra AyanSinhaMahapatra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @OmkarPh, thanks!

Some minor things to note:

  1. Are https://github.com/nexB/scancode-workbench/tree/feature/unittests/test-old and https://github.com/nexB/scancode-workbench/tree/feature/unittests/test-db used currently and if not should they not be removed entirely?
  2. The husky pre-commit increases the time to create commits, and usually we run only linters and other smaller/faster checks in pre-commits, and not the full test-suite? This time will increase when there are more comprehensive tests so this is something that should be considered.

But we can do these separately too, feel free to merge.

@AyanSinhaMahapatra
Copy link
Member

Merging! #591 (review) can be addressed at #556

@AyanSinhaMahapatra AyanSinhaMahapatra merged commit f42d601 into v4.0-react-typescript Oct 25, 2023
10 checks passed
@AyanSinhaMahapatra AyanSinhaMahapatra deleted the feature/unittests branch October 25, 2023 14:09
@OmkarPh
Copy link
Collaborator Author

OmkarPh commented Oct 25, 2023

LGTM @OmkarPh, thanks!

Some minor things to note:

  1. Are https://github.com/nexB/scancode-workbench/tree/feature/unittests/test-old and https://github.com/nexB/scancode-workbench/tree/feature/unittests/test-db used currently and if not should they not be removed entirely?

This, was fixed in other branch.
If you see the v4.0-react-typescript branch, these don't exist there

  1. The husky pre-commit increases the time to create commits, and usually we run only linters and other smaller/faster checks in pre-commits, and not the full test-suite? This time will increase when there are more comprehensive tests so this is something that should be considered.

But we can do these separately too, feel free to merge.

Ohk, lets discuss about this later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AyanSinhaMahapatra AyanSinhaMahapatra AyanSinhaMahapatra approved these changes

@TG1999 TG1999 Awaiting requested review from TG1999

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Husky pre-commit hooks for tests
2 participants
@OmkarPh @AyanSinhaMahapatra